Details

Reviewers

varun
bartek

Commits

rCOMMccb92e0486e1: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies

Summary

This diff introduces the integration of the shared Tunnelbroker-client Rust library into the keyserver using the napi-rs as a dependency.
We are updating the Cargo.toml file for the rust-node-addon and updating the Dockerfile to copy the tunnelbroker-client shared library inside the container.

Linear task: ENG-2729

Test Plan

All services should be built successfully according to the CI.

Diff Detail

Repository

rCOMM Comm

Branch

keyserver-add-tb-client-package

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Jan 17 2023, 6:40 AM

• max held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 17 2023, 6:40 AM

Harbormaster failed remote builds in B15400: Diff 21000!Jan 17 2023, 6:43 AM

• max added a parent revision: D6281: [tunnelbroker-client] Adding Tunnelbroker tonic client initialization function.Jan 25 2023, 5:40 AM

• max added a parent revision: D5796: [keyserver] implement registerUser rpc with napi-rs/tonic/opaque-ke.Jan 25 2023, 5:42 AM

Rebasing, making changes in Dockerfile, making D5796 as a parent.

Harbormaster failed remote builds in B15633: Diff 21314!Jan 25 2023, 5:57 AM

• max edited the summary of this revision. (Show Details)Jan 25 2023, 5:59 AM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: varun, bartek.

Adding copying of protobuf files into the Dockerfile.

Harbormaster failed remote builds in B15634: Diff 21315!Jan 25 2023, 6:17 AM

• max published this revision for review.Jan 25 2023, 6:27 AM

• max planned changes to this revision.

Installing protoc by the script.

Harbormaster failed remote builds in B15642: Diff 21324!Jan 25 2023, 9:28 AM

• max planned changes to this revision.Jan 25 2023, 9:28 AM

Fixing the install protoc script running.

• max planned changes to this revision.Jan 25 2023, 9:59 AM

Harbormaster failed remote builds in B15645: Diff 21327!Jan 25 2023, 10:04 AM

Forcing ot install protoc out of buildkite.

• max planned changes to this revision.Jan 25 2023, 10:14 AM

Harbormaster failed remote builds in B15646: Diff 21328!Jan 25 2023, 10:18 AM

Adding scripts to copy.

• max planned changes to this revision.Jan 25 2023, 10:27 AM

Harbormaster failed remote builds in B15647: Diff 21329!Jan 25 2023, 10:31 AM

ashoat added a subscriber: • jon.Jan 25 2023, 12:52 PM

ashoat added inline comments.

keyserver/addons/rust-node-addon/install_external_deps.sh
5–12 ↗	(On Diff #21329)	I think there's some reason for this logic, maybe @jon knows

Adding cmake to dependencies.

• max planned changes to this revision.Jan 26 2023, 4:35 AM

• max marked an inline comment as done.Jan 26 2023, 4:38 AM

• max added inline comments.

keyserver/addons/rust-node-addon/install_external_deps.sh
5–12 ↗	(On Diff #21329)	I think there's some reason for this logic, maybe @jon knows This came from D5796 where we are installing `protoc` using the `apt` when not in a CI workflow, but we must install the `protoc` using the `install_protobuf.sh` anyway because the `file contains proto3 optional fields` error (protoc version inconsistency).

Harbormaster failed remote builds in B15660: Diff 21357!Jan 26 2023, 4:39 AM

Updating ENG-2808 on the protoc build issue.

ashoat added inline comments.Jan 26 2023, 7:17 AM

keyserver/addons/rust-node-addon/install_external_deps.sh
5–12 ↗	(On Diff #21329)	You're breaking behavior though, aren't you? As mentioned above, this condition was here for a reason. It seems like you are going to cause the installation to occur in places where it should not, just so you can get your logic to work. It's important to consider "why" some code exists, instead of hammering things until they work for you

Rebasing on parent changes.

• max planned changes to this revision.Jan 26 2023, 12:07 PM

• max marked an inline comment as done.Jan 26 2023, 12:10 PM

• max added inline comments.

keyserver/addons/rust-node-addon/install_external_deps.sh
5–12 ↗	(On Diff #21329)	You're breaking behavior though, aren't you? As mentioned above, this condition was here for a reason. It seems like you are going to cause the installation to occur in places where it should not, just so you can get your logic to work. It's important to consider "why" some code exists, instead of hammering things until they work for you That was a "draft" diff which included changes that must/can be in the parent D5796. I think I should mark it as a draft in a title as well along with the "changes planned" state, until its ready.

Harbormaster completed remote builds in B15687: Diff 21390.Jan 26 2023, 12:21 PM

• max requested review of this revision.Jan 26 2023, 12:26 PM

• max marked an inline comment as done.

• max added a child revision: D6459: [keyserver] Adding Tunnelbroker-client napi-rs class constructor.Jan 30 2023, 2:30 AM

• max edited parent revisions, added: D6284: [tunnelbroker-client] Adding `publish_message` client function; removed: D6281: [tunnelbroker-client] Adding Tunnelbroker tonic client initialization function.Jan 30 2023, 2:47 AM

Accepting with one wording change inline

keyserver/Dockerfile
127 ↗	(On Diff #21390)
keyserver/addons/rust-node-addon/Cargo.toml
26 ↗	(On Diff #21390)	FWIW this kind of relative path appears to be breaking the Windows GitHub CI workflow... I paired with jon today to try to resolve it but no luck. Will try to sync with @ashoat because it might have something to do with node_modules that I don't understand

This revision is now accepted and ready to land.Jan 31 2023, 9:15 PM

Let's make sure we don't land this until we have clarity on the Windows GitHub issue, or at least we should be ready to revert it immediately if it breaks that

In D6283#194441, @ashoat wrote:

Let's make sure we don't land this until we have clarity on the Windows GitHub issue, or at least we should be ready to revert it immediately if it breaks that

I'll check if it's resolved first, or will try on the GitHub branch first.

Fixing comment.

• max marked an inline comment as done.Feb 2 2023, 5:15 AM

Harbormaster failed remote builds in B16000: Diff 21844!Feb 2 2023, 5:24 AM

Rebasing on parent changes.

Harbormaster completed remote builds in B16540: Diff 22628.Feb 15 2023, 2:06 PM

Closed by commit rCOMMccb92e0486e1: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies (authored by • max). · Explain WhyFeb 15 2023, 2:08 PM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMMccb92e0486e1: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.

• max removed a child revision: D6459: [keyserver] Adding Tunnelbroker-client napi-rs class constructor.Feb 21 2023, 10:53 AM

Diff 21315

View Options

keyserver/Dockerfile

	require File.join(File.dirname(`node --print "require.resolve('expo/package.json')"`), "scripts/autolinking")			require File.join(File.dirname(`node --print "require.resolve('expo/package.json')"`), "scripts/autolinking")
	require File.join(File.dirname(`node --print "require.resolve('react-native/package.json')"`), "scripts/react_native_pods")			require File.join(File.dirname(`node --print "require.resolve('react-native/package.json')"`), "scripts/react_native_pods")
	require File.join(File.dirname(`node --print "require.resolve('@react-native-community/cli-platform-ios/package.json')"`), "native_modules")			require File.join(File.dirname(`node --print "require.resolve('@react-native-community/cli-platform-ios/package.json')"`), "native_modules")

	platform :ios, '12.0'			platform :ios, '12.0'

	require 'json'			require 'json'
	podfile_properties = JSON.parse(File.read('./Podfile.properties.json')) rescue {}

	target 'Comm' do			def common_comm_target_pods
	pod 'ReactNativeKeyboardTrackingView', :path => '../../node_modules/react-native-keyboard-tracking-view'
	pod 'ReactNativeKeyboardInput', :path => '../../node_modules/react-native-keyboard-input'
	pod 'react-native-ffmpeg/min-lts', :podspec => '../../node_modules/react-native-ffmpeg/react-native-ffmpeg.podspec'
	pod 'react-native-video/VideoCaching', :podspec => '../../node_modules/react-native-video/react-native-video.podspec'
	pod 'SQLCipher-Amalgamation', :path => '../../node_modules/@commapp/sqlcipher-amalgamation'			pod 'SQLCipher-Amalgamation', :path => '../../node_modules/@commapp/sqlcipher-amalgamation'

	pod 'gRPC-C++', :podspec => './pod-patch/.patched/gRPC-C++/1.40.0/gRPC-C++.podspec.json'			pod 'gRPC-C++', :podspec => './pod-patch/.patched/gRPC-C++/1.40.0/gRPC-C++.podspec.json'
	pod 'gRPC-C++/Protobuf', :podspec => './pod-patch/.patched/gRPC-C++/1.40.0/gRPC-C++.podspec.json'			pod 'gRPC-C++/Protobuf', :podspec => './pod-patch/.patched/gRPC-C++/1.40.0/gRPC-C++.podspec.json'
	pod 'gRPC-Core', :podspec => './pod-patch/.patched/gRPC-Core/1.40.0/gRPC-Core.podspec.json'			pod 'gRPC-Core', :podspec => './pod-patch/.patched/gRPC-Core/1.40.0/gRPC-Core.podspec.json'
	pod 'Protobuf-C++', '3.15.8'			pod 'Protobuf-C++', '3.15.8'
				end

				target 'Comm' do
				pod 'ReactNativeKeyboardTrackingView', :path => '../../node_modules/react-native-keyboard-tracking-view'
				pod 'ReactNativeKeyboardInput', :path => '../../node_modules/react-native-keyboard-input'
				pod 'react-native-video/VideoCaching', :podspec => '../../node_modules/react-native-video/react-native-video.podspec'
				pod 'react-native-ffmpeg/min-lts', :podspec => '../../node_modules/react-native-ffmpeg/react-native-ffmpeg.podspec'
				common_comm_target_pods

	use_expo_modules!			use_expo_modules!
	config = use_native_modules!			config = use_native_modules!
				podfile_properties = JSON.parse(File.read('./Podfile.properties.json')) rescue {}
	use_react_native!(			use_react_native!(
	:path => config[:reactNativePath],			:path => config[:reactNativePath],
	# to enable hermes on iOS, change `false` to `true` and then install pods			# to enable hermes on iOS, change `false` to `true` and then install pods
	:hermes_enabled => podfile_properties['expo.jsEngine'] == 'hermes'			:hermes_enabled => podfile_properties['expo.jsEngine'] == 'hermes'
	)			)

	# Enables Flipper.			# Enables Flipper.
	#			#
	# Note that if you have use_frameworks! enabled, Flipper will not work and			# Note that if you have use_frameworks! enabled, Flipper will not work and
	# you should disable these next few lines.			# you should disable these next few lines.
	use_flipper!({ "Flipper-DoubleConversion" => "1.1.7" })			use_flipper!({ "Flipper-DoubleConversion" => "1.1.7" })
				end

				target 'NotificationService' do
				common_comm_target_pods
				pod 'OLMKit', :path => "../../node_modules/olm"
				pod 'RCT-Folly', :podspec => "../../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec"

				# Lines below are only needed to compile and use Expo Secure Store in Notification Service.
				# If Apple disapproves 'APPLICATION_EXTENSION_API_ONLY' flag then we can safely delete them and use
				# customized Expo Secure Store that does not depend on ExpoModulesCore
				podfile_properties = JSON.parse(File.read('./Podfile.properties.json')) rescue {}
				use_expo_modules!
				use_react_native!(
				:path => "../../node_modules/react-native",
				:hermes_enabled => podfile_properties['expo.jsEngine'] == 'hermes'
				)
				end

	post_install do \|installer\|			post_install do \|installer\|
				ashoatUnsubmitted Not Done Inline Actions Does this apply to all targets now? Are we sure we want to apply it to all targets? Is it possibly that we're inadvertedly applying it to some targets we haven't considered? (Targets that aren't the Comm app, or the notification service extension) ashoat: Does this apply to all targets now? Are we sure we want to apply it to all targets? Is it…
				marcinAuthorUnsubmitted Done Inline Actions There are two changes here compared to master branch: post_install hook is moved from target 'Comm' scope to global Podfile scope some lines are added that disable APPLICATION_EXTENSION_API_ONLY flag to enable CommonCpp sources compilation in 'NotificationService' target. Let me explain why those changes should not raise concern. Ad. 1) According to this doc: https://www.rubydoc.info/github/CocoaPods/Core/Pod%2FPodfile%2FDSL:post_install post_install is a hook applied just before XCode project is written to disk. According to this doc: https://www.rubydoc.info/gems/cocoapods-core/0.34.1/Pod/Podfile/DSL Podfile hooks always exist in global scope. Even if this post_install hook was written inside target 'Comm' scope its behaviour would be the same as if it was in global scope. This is even more confirmed by the fact that an attempt to write multiple post_install hooks (e.g. each per target) leads to errors: https://github.com/CocoaPods/CocoaPods/issues/6172. Ad. 2) Now that we established that we cannot have multiple post_install hooks and the one that we have should be in global scope we can admit it is impossible to use this flag anywhere else. marcin: There are two changes here compared to master branch: 1) post_install hook is moved from target…
				ashoatUnsubmitted Not Done Inline Actions Thanks for the explanation! ashoat: Thanks for the explanation!
	react_native_post_install(installer)			react_native_post_install(installer)
	__apply_Xcode_12_5_M1_post_install_workaround(installer)			__apply_Xcode_12_5_M1_post_install_workaround(installer)

	# Excluding arm64 because M1 simulator isn't supported yet			# Excluding arm64 because M1 simulator isn't supported yet
	# Excluding 32-bit x86 because nobody uses it and it causes compilation issues			# Excluding 32-bit x86 because nobody uses it and it causes compilation issues
	installer.pods_project.build_configurations.each do \|config\|			installer.pods_project.build_configurations.each do \|config\|
	config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = "arm64 i386"			config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = "arm64 i386"
				ashoatUnsubmitted Not Done Inline Actions It's a bit confusing to me that we exclude both of these here, but in the `project.pbxproj` only `arm64` is mentioned. Do you know why that is? ashoat: It's a bit confusing to me that we exclude both of these here, but in the `project.pbxproj`…
				marcinAuthorUnsubmitted Done Inline Actions Build settings in the XCode project refer to targets: Comm and NotificationService. This line changes build settings for pods. I did not modify this line and according to the explanation above it has alway been that we exclude both architectures for all pods. I do not know why it is that, but it is not related to any change introduced in this diff. Target 'Comm' excluded only amr64 architecture before I started to work on this issue and the very recent changes I introduced were to unify excluded architectures for both Comm and NotificationService. Would you like me to try whether we can exclude i386 arch for XCode targets as well? marcin: Build settings in the XCode project refer to targets: Comm and NotificationService. This line…
				ashoatUnsubmitted Not Done Inline Actions No, that's alright – thanks for this explanation ashoat: No, that's alright – thanks for this explanation
	config.build_settings['OTHER_CPLUSPLUSFLAGS'] = '-DDONT_AUTOINSTALL_REANIMATED'			config.build_settings['OTHER_CPLUSPLUSFLAGS'] = '-DDONT_AUTOINSTALL_REANIMATED'
	end			end

				# Lines below are only needed to compile and use Expo Secure Store in Notification Service.
				# If Apple disapproves 'APPLICATION_EXTENSION_API_ONLY' flag then we can safely delete them and use
				# customized Expo Secure Store that does not depend on ExpoModulesCore
				installer.pods_project.targets.each do \|target\|
				target.build_configurations.each do \|config\|
				config.build_settings['APPLICATION_EXTENSION_API_ONLY'] = 'NO'
				end
	end			end
				ashoatUnsubmitted Not Done Inline Actions There's an extraneous space at the end of this line ashoat: There's an extraneous space at the end of this line
	end			end

View Options

keyserver/addons/rust-node-addon/Cargo.toml

	require File.join(File.dirname(`node --print "require.resolve('expo/package.json')"`), "scripts/autolinking")			require File.join(File.dirname(`node --print "require.resolve('expo/package.json')"`), "scripts/autolinking")
	require File.join(File.dirname(`node --print "require.resolve('react-native/package.json')"`), "scripts/react_native_pods")			require File.join(File.dirname(`node --print "require.resolve('react-native/package.json')"`), "scripts/react_native_pods")
	require File.join(File.dirname(`node --print "require.resolve('@react-native-community/cli-platform-ios/package.json')"`), "native_modules")			require File.join(File.dirname(`node --print "require.resolve('@react-native-community/cli-platform-ios/package.json')"`), "native_modules")

	platform :ios, '12.0'			platform :ios, '12.0'

	require 'json'			require 'json'
	podfile_properties = JSON.parse(File.read('./Podfile.properties.json')) rescue {}

	target 'Comm' do			def common_comm_target_pods
	pod 'ReactNativeKeyboardTrackingView', :path => '../../node_modules/react-native-keyboard-tracking-view'
	pod 'ReactNativeKeyboardInput', :path => '../../node_modules/react-native-keyboard-input'
	pod 'react-native-ffmpeg/min-lts', :podspec => '../../node_modules/react-native-ffmpeg/react-native-ffmpeg.podspec'
	pod 'react-native-video/VideoCaching', :podspec => '../../node_modules/react-native-video/react-native-video.podspec'
	pod 'SQLCipher-Amalgamation', :path => '../../node_modules/@commapp/sqlcipher-amalgamation'			pod 'SQLCipher-Amalgamation', :path => '../../node_modules/@commapp/sqlcipher-amalgamation'

	pod 'gRPC-C++', :podspec => './pod-patch/.patched/gRPC-C++/1.40.0/gRPC-C++.podspec.json'			pod 'gRPC-C++', :podspec => './pod-patch/.patched/gRPC-C++/1.40.0/gRPC-C++.podspec.json'
	pod 'gRPC-C++/Protobuf', :podspec => './pod-patch/.patched/gRPC-C++/1.40.0/gRPC-C++.podspec.json'			pod 'gRPC-C++/Protobuf', :podspec => './pod-patch/.patched/gRPC-C++/1.40.0/gRPC-C++.podspec.json'
	pod 'gRPC-Core', :podspec => './pod-patch/.patched/gRPC-Core/1.40.0/gRPC-Core.podspec.json'			pod 'gRPC-Core', :podspec => './pod-patch/.patched/gRPC-Core/1.40.0/gRPC-Core.podspec.json'
	pod 'Protobuf-C++', '3.15.8'			pod 'Protobuf-C++', '3.15.8'
				end

				target 'Comm' do
				pod 'ReactNativeKeyboardTrackingView', :path => '../../node_modules/react-native-keyboard-tracking-view'
				pod 'ReactNativeKeyboardInput', :path => '../../node_modules/react-native-keyboard-input'
				pod 'react-native-video/VideoCaching', :podspec => '../../node_modules/react-native-video/react-native-video.podspec'
				pod 'react-native-ffmpeg/min-lts', :podspec => '../../node_modules/react-native-ffmpeg/react-native-ffmpeg.podspec'
				common_comm_target_pods

	use_expo_modules!			use_expo_modules!
	config = use_native_modules!			config = use_native_modules!
				podfile_properties = JSON.parse(File.read('./Podfile.properties.json')) rescue {}
	use_react_native!(			use_react_native!(
	:path => config[:reactNativePath],			:path => config[:reactNativePath],
	# to enable hermes on iOS, change `false` to `true` and then install pods			# to enable hermes on iOS, change `false` to `true` and then install pods
	:hermes_enabled => podfile_properties['expo.jsEngine'] == 'hermes'			:hermes_enabled => podfile_properties['expo.jsEngine'] == 'hermes'
	)			)

	# Enables Flipper.			# Enables Flipper.
	#			#
	# Note that if you have use_frameworks! enabled, Flipper will not work and			# Note that if you have use_frameworks! enabled, Flipper will not work and
	# you should disable these next few lines.			# you should disable these next few lines.
	use_flipper!({ "Flipper-DoubleConversion" => "1.1.7" })			use_flipper!({ "Flipper-DoubleConversion" => "1.1.7" })
				end

				target 'NotificationService' do
				common_comm_target_pods
				pod 'OLMKit', :path => "../../node_modules/olm"
				pod 'RCT-Folly', :podspec => "../../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec"

				# Lines below are only needed to compile and use Expo Secure Store in Notification Service.
				# If Apple disapproves 'APPLICATION_EXTENSION_API_ONLY' flag then we can safely delete them and use
				# customized Expo Secure Store that does not depend on ExpoModulesCore
				podfile_properties = JSON.parse(File.read('./Podfile.properties.json')) rescue {}
				use_expo_modules!
				use_react_native!(
				:path => "../../node_modules/react-native",
				:hermes_enabled => podfile_properties['expo.jsEngine'] == 'hermes'
				)
				end

	post_install do \|installer\|			post_install do \|installer\|
				ashoatUnsubmitted Not Done Inline Actions Does this apply to all targets now? Are we sure we want to apply it to all targets? Is it possibly that we're inadvertedly applying it to some targets we haven't considered? (Targets that aren't the Comm app, or the notification service extension) ashoat: Does this apply to all targets now? Are we sure we want to apply it to all targets? Is it…
				marcinAuthorUnsubmitted Done Inline Actions There are two changes here compared to master branch: post_install hook is moved from target 'Comm' scope to global Podfile scope some lines are added that disable APPLICATION_EXTENSION_API_ONLY flag to enable CommonCpp sources compilation in 'NotificationService' target. Let me explain why those changes should not raise concern. Ad. 1) According to this doc: https://www.rubydoc.info/github/CocoaPods/Core/Pod%2FPodfile%2FDSL:post_install post_install is a hook applied just before XCode project is written to disk. According to this doc: https://www.rubydoc.info/gems/cocoapods-core/0.34.1/Pod/Podfile/DSL Podfile hooks always exist in global scope. Even if this post_install hook was written inside target 'Comm' scope its behaviour would be the same as if it was in global scope. This is even more confirmed by the fact that an attempt to write multiple post_install hooks (e.g. each per target) leads to errors: https://github.com/CocoaPods/CocoaPods/issues/6172. Ad. 2) Now that we established that we cannot have multiple post_install hooks and the one that we have should be in global scope we can admit it is impossible to use this flag anywhere else. marcin: There are two changes here compared to master branch: 1) post_install hook is moved from target…
				ashoatUnsubmitted Not Done Inline Actions Thanks for the explanation! ashoat: Thanks for the explanation!
	react_native_post_install(installer)			react_native_post_install(installer)
	__apply_Xcode_12_5_M1_post_install_workaround(installer)			__apply_Xcode_12_5_M1_post_install_workaround(installer)

	# Excluding arm64 because M1 simulator isn't supported yet			# Excluding arm64 because M1 simulator isn't supported yet
	# Excluding 32-bit x86 because nobody uses it and it causes compilation issues			# Excluding 32-bit x86 because nobody uses it and it causes compilation issues
	installer.pods_project.build_configurations.each do \|config\|			installer.pods_project.build_configurations.each do \|config\|
	config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = "arm64 i386"			config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = "arm64 i386"
				ashoatUnsubmitted Not Done Inline Actions It's a bit confusing to me that we exclude both of these here, but in the `project.pbxproj` only `arm64` is mentioned. Do you know why that is? ashoat: It's a bit confusing to me that we exclude both of these here, but in the `project.pbxproj`…
				marcinAuthorUnsubmitted Done Inline Actions Build settings in the XCode project refer to targets: Comm and NotificationService. This line changes build settings for pods. I did not modify this line and according to the explanation above it has alway been that we exclude both architectures for all pods. I do not know why it is that, but it is not related to any change introduced in this diff. Target 'Comm' excluded only amr64 architecture before I started to work on this issue and the very recent changes I introduced were to unify excluded architectures for both Comm and NotificationService. Would you like me to try whether we can exclude i386 arch for XCode targets as well? marcin: Build settings in the XCode project refer to targets: Comm and NotificationService. This line…
				ashoatUnsubmitted Not Done Inline Actions No, that's alright – thanks for this explanation ashoat: No, that's alright – thanks for this explanation
	config.build_settings['OTHER_CPLUSPLUSFLAGS'] = '-DDONT_AUTOINSTALL_REANIMATED'			config.build_settings['OTHER_CPLUSPLUSFLAGS'] = '-DDONT_AUTOINSTALL_REANIMATED'
	end			end

				# Lines below are only needed to compile and use Expo Secure Store in Notification Service.
				# If Apple disapproves 'APPLICATION_EXTENSION_API_ONLY' flag then we can safely delete them and use
				# customized Expo Secure Store that does not depend on ExpoModulesCore
				installer.pods_project.targets.each do \|target\|
				target.build_configurations.each do \|config\|
				config.build_settings['APPLICATION_EXTENSION_API_ONLY'] = 'NO'
				end
	end			end
				ashoatUnsubmitted Not Done Inline Actions There's an extraneous space at the end of this line ashoat: There's an extraneous space at the end of this line
	end			end

[keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 21315

keyserver/Dockerfile

keyserver/addons/rust-node-addon/Cargo.toml

[keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependenciesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21315

keyserver/Dockerfile

keyserver/addons/rust-node-addon/Cargo.toml

[keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies
ClosedPublic
Actions

Revision Contents
Changeset List