Page MenuHomePhabricator
Differential D6396

[native] Don't crash if Alchemy API key is missing
ClosedPublic
Actions

Authored by ashoat on Jan 26 2023, 9:00 AM.
Tags
None
Referenced Files
F3489654: D6396.id21376.diff
Wed, Dec 18, 1:19 PM
F3489653: D6396.id21373.diff
Wed, Dec 18, 1:19 PM
F3488896: D6396.diff
Wed, Dec 18, 11:05 AM
Unknown Object (File)
Fri, Dec 6, 7:39 PM
Unknown Object (File)
Nov 11 2024, 12:07 AM
Unknown Object (File)
Nov 8 2024, 3:08 AM
Unknown Object (File)
Nov 8 2024, 3:08 AM
Unknown Object (File)
Nov 8 2024, 3:08 AM
View All 93 Files
Subscribers
None

Details

Reviewers
kamil
• przemek
atul
ginsu
marcin
tomek
Commits
rCOMMbde0aad9e5ec: [native] Don't crash if Alchemy API key is missing
Summary

This fixes ENG-2836. I should've tested this scenario before landing D6373. The docs seemed to indicate that the Alchemy API key was optional, and I know Wagmi "works" without it. But now I think it's only optional for Ethers.js for testnet or something?

Test Plan

Confirm crash no longer occurs when Alchemy API key is missing (no native/facts/alchemy.json file) in native app

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/fix_ethers_crash
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
components/
4 lines
native/
utils/
8 lines

Diff 21373

View Options

lib/components/ens-cache-provider.react.js

Loading...
View Options

native/utils/ethers-utils.js

Loading...