Page MenuHomePhabricator
Differential D5994

[native] throw exception when migration process will fail
ClosedPublic
Actions

Authored by kamil on Dec 22 2022, 2:51 AM.
Tags
None
Referenced Files
F1722356: D5994.diff
Thu, May 9, 9:45 PM
Unknown Object (File)
Sun, Apr 28, 6:50 AM
Unknown Object (File)
Sun, Apr 28, 6:50 AM
Unknown Object (File)
Sun, Apr 28, 6:50 AM
Unknown Object (File)
Sun, Apr 28, 6:47 AM
Unknown Object (File)
Sun, Apr 28, 6:24 AM
Unknown Object (File)
Apr 3 2024, 2:30 AM
Unknown Object (File)
Apr 3 2024, 2:30 AM
View All 69 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
marcin
tomek
Commits
rCOMM78591724e16f: [native] throw exception when migration process will fail
Summary

Context in ENG-2068

Test Plan

Force migration and creating new db process to fail and check if exception is thrown

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Dec 22 2022, 2:51 AM
kamil held this revision as a draft.
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 22 2022, 2:51 AM
Harbormaster completed remote builds in B14678: Diff 20017.Dec 22 2022, 3:03 AM
kamil added a parent revision: D5993: [native/CommCoreModule] add function check if database is malformed and needs deletion.Dec 22 2022, 3:24 AM
kamil added a child revision: D5995: [native] clear database when malformation is detected.
kamil published this revision for review.Dec 22 2022, 3:31 AM
marcin accepted this revision.Dec 26 2022, 2:17 AM
marcin added a reviewer: tomek.
tomek accepted this revision.Dec 27 2022, 4:24 AM
This revision is now accepted and ready to land.Dec 27 2022, 4:24 AM
tomek added a comment.Dec 27 2022, 4:25 AM

As a test plan, have you also checked creating a new db?

kamil mentioned this in D5989: [native] refactor `clearSensitiveData()` method to static member of `SQLiteQueryExecutor`.Dec 29 2022, 6:50 AM
kamil edited the test plan for this revision. (Show Details)Jan 9 2023, 4:24 AM
kamil added a comment.Jan 9 2023, 4:27 AM
In D5994#181372, @tomek wrote:

As a test plan, have you also checked creating a new db?

Sure, I've added this to the test plan

kamil updated this revision to Diff 21583.Jan 30 2023, 4:07 AM

rename source

Harbormaster completed remote builds in B15837: Diff 21583.Jan 30 2023, 4:20 AM
Closed by commit rCOMM78591724e16f: [native] throw exception when migration process will fail (authored by kamil). · Explain WhyFeb 1 2023, 4:00 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM78591724e16f: [native] throw exception when migration process will fail.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
10 lines

Diff 21583

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...