[native/Android] attach operations on `SecureStore` and `PlatformSpecificTools` to JVM
ClosedPublic
Actions

Authored by kamil on Jan 27 2023, 6:56 AM.

Details

Reviewers

marcin
tomek

Commits

Summary

We should support attaching operations to JVM at very low level to make using Tools safe (without need to support this while using exact functions).
There are cases in code where supporting this was omitted and could lead to problems (described in ENG-2787)

Test Plan

Logout on Android app (emulator and device) and check whether works properly.
This change will not affect iOS.

Repository

rCOMM Comm

Branch

land-jvm

Lint

No Lint Coverage

Unit

No Test Coverage

kamil held this revision as a draft.

kamil edited the test plan for this revision. (Show Details)Jan 27 2023, 7:01 AM

kamil published this revision for review.Jan 27 2023, 7:03 AM

kamil edited the test plan for this revision. (Show Details)

kamil added inline comments.

native/android/app/src/cpp/jniHelpers.h
32 ↗	(On Diff #21462)	another option might be using `inline` function to shorten code, because this is simply one-line function, but looks like in codebase this pattern is preferred so sticking to this one

marcin added inline comments.

native/android/app/src/cpp/jniHelpers.h
32 ↗	(On Diff #21462)	Let's name a class with a noun - not an adjective. Perhaps `NativeAndroidAccessProvider` could work, but up to you.

This revision is now accepted and ready to land.Jan 27 2023, 7:25 AM

This revision now requires review to proceed.Jan 27 2023, 7:27 AM

native/android/app/src/cpp/jniHelpers.h
32 ↗	(On Diff #21462)	Regarding the `inline`, the docs https://en.cppreference.com/w/cpp/language/inline say Since this meaning of the keyword inline is non-binding, compilers are free to use inline substitution for any function that's not marked inline, and are free to generate function calls to any function marked inline. Additionally, for member functions https://isocpp.org/wiki/faq/inline-functions#inline-member-fns-more the `inline` keyword is implicit. I'm not sure how about `struct`.