Paths

Table of Contentst

Differential D6279

[tunnelbroker-client] Adding of the `build.rs` cargo file to compile protobuf
ClosedPublic
Actions

Authored by • max on Jan 17 2023, 6:07 AM.

Tags

None

Referenced Files

	F3485810: D6279.diff
	Wed, Dec 18, 1:15 AM

	Unknown Object (File)
	Nov 15 2024, 5:29 PM

	Unknown Object (File)
	Nov 8 2024, 10:18 AM

	Unknown Object (File)
	Nov 6 2024, 9:55 PM

	Unknown Object (File)
	Oct 30 2024, 8:04 PM

	Unknown Object (File)
	Oct 29 2024, 6:50 AM

	Unknown Object (File)
	Oct 27 2024, 5:43 PM

	Unknown Object (File)
	Sep 29 2024, 12:21 AM

Subscribers

Details

Reviewers

• jon
bartek
varun

Commits

rCOMM3e22505179f4: [tunnelbroker-client] Adding of the `build.rs` cargo file to compile protobuf

Summary

This diff introduces adding build.rs file with the Tunnelbroker's protobuf file compilation inside.
Generated files will be used in the following gRPC Tonic client from D6281 and beyond.

Linear task: ENG-2728

Test Plan

To run build and test patch to the D6281 and run nix develop --accept-flake-config -c bash -c "cargo build".
The expected result is that the library will be successfully built.

Diff Detail

Repository

Branch

tb-add-build-rs

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Jan 17 2023, 6:07 AM

• max held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 17 2023, 6:07 AM

Harbormaster completed remote builds in B15394: Diff 20994.Jan 17 2023, 6:21 AM

• max mentioned this in D6277: [tunnelbroker-client] Creating a Cargo project file.Jan 17 2023, 6:51 AM

• max published this revision for review.Jan 17 2023, 7:09 AM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: • jon, bartek.

• max added a parent revision: D6278: [tunnelbroker-client] Adding `shared/tunnelbroker-client` target folder to the `.gitignore`.

• max added a child revision: D6281: [tunnelbroker-client] Adding Tunnelbroker tonic client initialization function.Jan 17 2023, 7:15 AM

• jon accepted this revision.Jan 17 2023, 11:14 AM

This revision is now accepted and ready to land.Jan 17 2023, 11:14 AM

• max added a reviewer: varun.Jan 25 2023, 4:59 AM

This revision now requires review to proceed.Jan 25 2023, 4:59 AM

Adding @varun for a final pass.

varun accepted this revision.Jan 25 2023, 12:20 PM

This revision is now accepted and ready to land.Jan 25 2023, 12:20 PM

bartek accepted this revision.Jan 31 2023, 9:11 AM

• max mentioned this in rCOMM127dbcc6f0ea: [tunnelbroker-client] Creating a Cargo project file.Feb 1 2023, 6:39 AM

Rebasing on master changes.

Harbormaster completed remote builds in B15934: Diff 21757.Feb 1 2023, 7:14 AM

Adding an empty src/lib.rs to pass the updated rs linter. src/lib.rs will be populated in the next D6281 diff.

Harbormaster completed remote builds in B15937: Diff 21760.Feb 1 2023, 7:56 AM

Closed by commit rCOMM3e22505179f4: [tunnelbroker-client] Adding of the `build.rs` cargo file to compile protobuf (authored by • max). · Explain WhyFeb 1 2023, 9:09 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM3e22505179f4: [tunnelbroker-client] Adding of the `build.rs` cargo file to compile protobuf.

Revision Contents
Changeset List

Path

Size

shared/

tunnelbroker-client/

5 lines

src/

1 line

Diff 21760

shared/tunnelbroker-client/build.rs

Loading...

shared/tunnelbroker-client/src/lib.rs

Loading...