Page MenuHomePhabricator

[lib] Migrate CreateThread/CreateSubThread notifTexts to use EntityText
ClosedPublic

Authored by ashoat on Feb 4 2023, 10:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 12:51 PM
Unknown Object (File)
Fri, Dec 20, 8:44 AM
Unknown Object (File)
Sat, Dec 14, 1:31 PM
Unknown Object (File)
Sat, Dec 14, 1:31 PM
Unknown Object (File)
Sat, Dec 14, 1:30 PM
Unknown Object (File)
Sat, Dec 14, 1:22 PM
Unknown Object (File)
Wed, Dec 4, 8:36 PM
Unknown Object (File)
Nov 18 2024, 7:33 PM
Subscribers

Details

Summary

Note that this introduces a require cycle by having message specs import directly from notif-utils, which imports into them. I think it's fine in modern Node.js.

Depends on D6577

Test Plan

Generated CreateThread and CreateSubThread messages on a web client in a chat with a different test user that is logged in on the iOS simulator. Background the iOS app and make sure the notif looks right

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage