[keyserver] Base setup of ethers.js and ENSCache
ClosedPublic
Actions

Authored by ashoat on Feb 4 2023, 5:56 PM.

Details

Reviewers

atul

Commits

rCOMM90cb990c058f: [keyserver] Base setup of ethers.js and ENSCache

Summary

Most callsites in keyserver will probably interact with getENSNames directly, but exposing the others doesn't hurt.

Test Plan

Tested in combination with later notif diffs

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 4 2023, 5:56 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 4 2023, 5:56 PM

ashoat added a child revision: D6573: [lib] Extend EntityText to support rendering thread names for notifs.Feb 4 2023, 5:58 PM

ashoat edited the summary of this revision. (Show Details)Feb 4 2023, 5:58 PM

ashoat added a parent revision: D6571: [lib][keyserver] Convert notificationTexts to async functions.

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 4 2023, 5:59 PM

Harbormaster failed remote builds in B16086: Diff 21973!

Harbormaster completed remote builds in B16086: Diff 21973.Feb 4 2023, 8:07 PM

ashoat requested review of this revision.Feb 4 2023, 8:07 PM

atul accepted this revision.Feb 4 2023, 8:11 PM

This revision is now accepted and ready to land.Feb 4 2023, 8:11 PM

Closed by commit rCOMM90cb990c058f: [keyserver] Base setup of ethers.js and ENSCache. · Explain WhyFeb 5 2023, 3:53 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM90cb990c058f: [keyserver] Base setup of ethers.js and ENSCache.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

utils/

ens-cache.js

28 lines

Diff 22051

View Options

keyserver/src/utils/ens-cache.js

[keyserver] Base setup of ethers.js and ENSCacheClosedPublicActions