[Android] Promote folly to library target
ClosedPublic
Actions

Authored by • jon on Jan 31 2023, 10:41 AM.

Details

Reviewers

• max
bartek
varun
atul

Commits

rCOMMae4e117d35b3: [Android] Promote folly to library target

Summary

Other CMake modules in native/cpp also need folly, so
we need to have folly as a well defined target which those files
can consume.

https://linear.app/comm/issue/ENG-2895

Test Plan

Android gate passes

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Jan 31 2023, 10:41 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 31 2023, 10:41 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 31 2023, 10:43 AM

Harbormaster failed remote builds in B15896: Diff 21697!

• jon edited the summary of this revision. (Show Details)Jan 31 2023, 10:55 AM

Lint

Harbormaster completed remote builds in B15900: Diff 21701.Jan 31 2023, 11:31 AM

• jon requested review of this revision.Jan 31 2023, 11:31 AM

Remove obsolete references to folly dependencies

Harbormaster completed remote builds in B15910: Diff 21716.Jan 31 2023, 2:13 PM

atul accepted this revision.Feb 1 2023, 8:01 AM

This revision is now accepted and ready to land.Feb 1 2023, 8:01 AM

• jon added a child revision: D6498: [Native] Remove CMake installation logic from native/cpp.Feb 1 2023, 12:17 PM

Closed by commit rCOMMae4e117d35b3: [Android] Promote folly to library target (authored by • jon). · Explain WhyFeb 6 2023, 7:22 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMae4e117d35b3: [Android] Promote folly to library target.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

CMakeLists.txt

39 lines

cmake/

folly-target.cmake

29 lines

Diff 22128

View Options

native/android/app/CMakeLists.txt