Page MenuHomePhabricator
Differential D6637

[web] Add ENSAvatar to `ConnectedWalletInfo` if set
ClosedPublic
Actions

Authored by atul on Feb 6 2023, 1:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 12:36 AM
Unknown Object (File)
Sun, Nov 10, 11:57 PM
Unknown Object (File)
Sun, Nov 10, 11:38 PM
Unknown Object (File)
Sun, Nov 10, 10:49 PM
Unknown Object (File)
Sun, Nov 10, 9:09 PM
Unknown Object (File)
Sun, Nov 10, 1:50 PM
Unknown Object (File)
Oct 12 2024, 1:57 AM
Unknown Object (File)
Sep 29 2024, 10:32 PM
View All 73 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
rohan
ginsu
Commits
rCOMM8bc2634638fd: [web] Add ENSAvatar to `ConnectedWalletInfo` if set
Summary

This brings us to full parity with the RainbowKit ConnectButton component.

Depends on D6636

Test Plan

Looks as expected:

7e2d65.png (1×916 px, 132 KB)

(when address set to vitalik.eth)

Continues looking as expected for addresses where ENS avatar isn't set:

586df6.png (1×966 px, 136 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 6 2023, 1:25 PM
atul edited the test plan for this revision. (Show Details)Feb 6 2023, 1:27 PM
atul edited the summary of this revision. (Show Details)
atul added a parent revision: D6636: [web] Replace RainbowKit `ConnectButton` with `ConnectedWalletInfo`.
atul published this revision for review.Feb 6 2023, 1:29 PM
atul added inline comments.
web/account/log-in-form.css
10 ↗(On Diff #22156)

Snuck outline -> border change to work around known Safari issue with outline and border-radius

(https://medium.com/@jeandesravines/use-border-radius-and-outline-simultaneously-on-safari-14ce92889e1f)

(https://github.com/google/model-viewer/issues/662)

atul updated this revision to Diff 22157.Feb 6 2023, 1:31 PM

reduce transition times a bit

Harbormaster completed remote builds in B16192: Diff 22156.Feb 6 2023, 1:41 PM
Harbormaster completed remote builds in B16193: Diff 22157.Feb 6 2023, 1:45 PM
atul added a child revision: D6638: [lib] Move `SWMansion.react` to `lib` so it can be shared across `web` and `landing`.Feb 6 2023, 5:52 PM
ashoat accepted this revision.Feb 6 2023, 5:56 PM
This revision is now accepted and ready to land.Feb 6 2023, 5:56 PM
atul updated this revision to Diff 22197.Feb 7 2023, 8:59 AM

rebase + land

This revision was landed with ongoing or failed builds.Feb 7 2023, 9:00 AM
Closed by commit rCOMM8bc2634638fd: [web] Add ENSAvatar to `ConnectedWalletInfo` if set (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM8bc2634638fd: [web] Add ENSAvatar to `ConnectedWalletInfo` if set.
Harbormaster completed remote builds in B16229: Diff 22197.Feb 7 2023, 9:14 AM

Revision Contents
Changeset List

Diff 22157

View Options

web/account/connected-wallet-info.css

Loading...
View Options

web/account/connected-wallet-info.react.js

Loading...
View Options

web/account/log-in-form.css

Loading...