ENG-2923
If checkForUpdates fails because of lack of the internet connection update-not-available won't run and the timer for checking updated won't be restarted. After this diff check for updates will be done continuously and only stopped between update-available and update-downloaded events (so the update won't downloaded multiple times).
Details
Details
Add some logging and check that checkForUpdates is called correctly, even in case of no network connection. Try updating to a new version.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
How about the case where we detect that an update is available, we stop an interval and then downloading the update fails?
| desktop/src/auto-update.js | ||
|---|---|---|
| 14 ↗ | (On Diff #22398) | Is it beneficial to introduce a new term schedule? Maybe we can use interval? |
| 20 ↗ | (On Diff #22398) | I'm not sure if I suggested something similar previously, but () => f() could be replaced by just f |
| desktop/src/auto-update.js | ||
|---|---|---|
| 20 ↗ | (On Diff #22398) | Note that this only works if autoUpdater.checkForUpdates is defined as an arrow function instead of a standard class function... otherwise this will be dropped unless you use bind |