Page MenuHomePhabricator

[web] Move web/apps directory to web/modals/apps
ClosedPublic

Authored by inka on Feb 21 2023, 3:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 7:05 PM
Unknown Object (File)
Tue, Nov 19, 11:29 AM
Unknown Object (File)
Tue, Nov 19, 11:29 AM
Unknown Object (File)
Tue, Nov 19, 11:29 AM
Unknown Object (File)
Tue, Nov 19, 11:29 AM
Unknown Object (File)
Tue, Nov 19, 11:28 AM
Unknown Object (File)
Tue, Nov 19, 11:23 AM
Unknown Object (File)
Oct 23 2024, 10:13 AM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-3044/change-apps-tab-to-be-a-modal
Moving files that correspond to the Apps tab, because according to the new designs the tab is supposed to be changed into a modal. But not that much of the current code will be changed, so to
make the review easier I'm moving the code first, an will change it later.

Test Plan

Run web app, checked that pressing the "+" button in the top bar still opoent the Apps tab, and it displays and works properly.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 21 2023, 3:27 AM
Harbormaster failed remote builds in B16687: Diff 22820!

Please rebase on master to fix iOS build

This revision is now accepted and ready to land.Feb 21 2023, 1:39 PM