Paths

Table of Contentst

Differential D6814

[web] Remove apps as a tab in code logic
ClosedPublic
Actions

Authored by inka on Feb 21 2023, 3:56 AM.

Tags

None

Referenced Files

	F3384764: D6814.id22937.diff
	Thu, Nov 28, 10:29 PM

	Unknown Object (File)
	Tue, Nov 19, 11:29 AM

	Unknown Object (File)
	Tue, Nov 19, 11:29 AM

	Unknown Object (File)
	Tue, Nov 19, 11:29 AM

	Unknown Object (File)
	Tue, Nov 19, 11:29 AM

	Unknown Object (File)
	Tue, Nov 19, 11:28 AM

	Unknown Object (File)
	Tue, Nov 19, 11:23 AM

	Unknown Object (File)
	Oct 23 2024, 10:13 AM

Subscribers

Details

Reviewers

tomek
kamil
michal

Commits

rCOMMf555ace6fb9b: [web] Remove apps as a tab in code logic

Summary

issue: https://linear.app/comm/issue/ENG-3044/change-apps-tab-to-be-a-modal
Since the apps tab is a modal (since D6812) the code logic that considers it a tab should be removed.
file lib/utils/url-utils.js was only used on web, so the changes don't influence native

Test Plan

Run flow check in web/. Searched for any occurences of 'apps' on web and checked that this is all that needs to be changed

Diff Detail

Repository

Branch

inka/web_drawer_continuation

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Feb 21 2023, 3:56 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptFeb 21 2023, 3:56 AM

inka added a parent revision: D6812: [web] Change apps tab to be a modal.Feb 21 2023, 3:57 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 21 2023, 4:02 AM

Harbormaster failed remote builds in B16691: Diff 22824!

inka requested review of this revision.Feb 21 2023, 4:26 AM

inka added a child revision: D6816: [web] Change import path and fix errors showing up when the typing is correct.

Rebase

Harbormaster failed remote builds in B16709: Diff 22862!Feb 21 2023, 7:36 AM

kamil accepted this revision.Feb 22 2023, 5:33 AM

This revision is now accepted and ready to land.Feb 22 2023, 5:33 AM

Rebase

Harbormaster completed remote builds in B16776: Diff 22937.Feb 22 2023, 10:18 AM

Closed by commit rCOMMf555ace6fb9b: [web] Remove apps as a tab in code logic (authored by • InkaSokolowska). · Explain WhyMar 1 2023, 12:38 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMMf555ace6fb9b: [web] Remove apps as a tab in code logic.

Revision Contents
Changeset List

Path

Size

lib/

utils/

5 lines

web/

3 lines

sidebar/

community-picker.react.js

5 lines

types/

2 lines

2 lines

Diff 22824

lib/utils/url-utils.js

Loading...

web/app.react.js

Loading...

web/sidebar/community-picker.react.js

Loading...

web/types/nav-types.js

Loading...

web/url-utils.js

Loading...