Page MenuHomePhabricator
Differential D6773

Extend PlatformSpecificTools CommonCpp api with an API to retrieve notifications olm account storage path
ClosedPublic
Actions

Authored by marcin on Feb 20 2023, 3:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 9:38 PM
Unknown Object (File)
Mon, Nov 4, 8:39 AM
Unknown Object (File)
Wed, Oct 30, 7:57 AM
Unknown Object (File)
Wed, Oct 30, 7:57 AM
Unknown Object (File)
Wed, Oct 30, 7:57 AM
Unknown Object (File)
Wed, Oct 30, 7:57 AM
Unknown Object (File)
Wed, Oct 30, 7:57 AM
Unknown Object (File)
Wed, Oct 30, 7:57 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
bartek
tomek
kamil
Commits
rCOMM1a211459c6b0: Extend PlatformSpecificTools CommonCpp api with an API to retrieve…
Summary

This differential extends PlatformSpecificTools CommonCpp api with an API to retrieve notifications olm account storage path. It also implements it on iOS and in C++ on Android. Relevant native Java method is implemented in parent differential to this one and is called via JNI
in Android C++ implementation.

Test Plan

Call PlatformSpecificTools::getNotificationsCryptoAccountPath() in NotificationService.mm and in AppDelegate.mm. This tests iOS. Call it somewhere in SQLiteQueryExecutor or CommCoreModule. This tests on Android (and iOS as well).

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Feb 20 2023, 3:21 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptFeb 20 2023, 3:21 AM
marcin added a parent revision: D6772: Implement native method on Android to get notifications olm account storage path.Feb 20 2023, 3:24 AM
marcin added 2 blocking reviewer(s): bartek, kamil.

Adding @bartek as blocking since he is native expert and adding @kamil as blocking since I am using an API that he implemented.

marcin added a child revision: D6774: Start NotificationsCryptoModule API definition and implementation.Feb 20 2023, 4:05 AM
marcin published this revision for review.Feb 20 2023, 4:43 AM
marcin edited the test plan for this revision. (Show Details)Feb 20 2023, 6:49 AM
Harbormaster failed remote builds in B16603: Diff 22709!Feb 20 2023, 7:17 AM
bartek accepted this revision.Feb 21 2023, 4:08 AM
marcin updated this revision to Diff 22877.Feb 21 2023, 10:47 AM

Rebase

Harbormaster completed remote builds in B16722: Diff 22877.Feb 21 2023, 11:02 AM
kamil accepted this revision.Feb 22 2023, 2:11 AM
This revision is now accepted and ready to land.Feb 22 2023, 2:11 AM
marcin updated this revision to Diff 23251.Feb 28 2023, 10:05 AM

Rebase before landing

Harbormaster failed remote builds in B16997: Diff 23251!Feb 28 2023, 10:09 AM
Harbormaster completed remote builds in B16997: Diff 23251.Feb 28 2023, 1:51 PM
marcin updated this revision to Diff 23305.Mar 1 2023, 1:20 AM

Rebase before landing

Harbormaster completed remote builds in B17022: Diff 23305.Mar 1 2023, 1:35 AM
Closed by commit rCOMM1a211459c6b0: Extend PlatformSpecificTools CommonCpp api with an API to retrieve… (authored by marcin). · Explain WhyMar 1 2023, 2:04 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM1a211459c6b0: Extend PlatformSpecificTools CommonCpp api with an API to retrieve….
ashoat added inline comments.Mar 6 2023, 11:12 AM
native/android/app/src/cpp/PlatformSpecificTools.cpp
52 ↗(On Diff #23318)

I'm not sure why, but this doesn't appear to be working. See here and here

ashoat added inline comments.Mar 6 2023, 11:27 AM
native/android/app/src/cpp/PlatformSpecificTools.cpp
52 ↗(On Diff #23318)

Ignore, this was incorrect

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
cpp/
15 lines
cpp/
CommonCpp/
Tools/
1 line
ios/
Comm/
14 lines

Diff 22877

View Options

native/android/app/src/cpp/PlatformSpecificTools.cpp

Loading...
View Options

native/cpp/CommonCpp/Tools/PlatformSpecificTools.h

Loading...
View Options

native/ios/Comm/PlatformSpecificTools.mm

Loading...