As mentioned in D6812 the import has to be fixed. We use useSelector from web/redux/redux-utils.js on web, because it adds proper typing. This change broke this file, because we should not be
quering an object for a field it doesn't have. Thus the other changes.
Details
Details
Run web app, checked that Apps directory modal displays its items correclty.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/modals/apps/apps-directory-modal.react.js | ||
|---|---|---|
| 40 ↗ | (On Diff #22938) | maybe I am missing context here but wondering we there is need to fix this that way, not eg. adding chat: true (because it's always enabled) to EnabledApps type, since chat is also an app? |
| web/modals/apps/apps-directory-modal.react.js | ||
|---|---|---|
| 40 ↗ | (On Diff #22938) | Me and @tomek talked about this and inn result this task was created: https://linear.app/comm/issue/ENG-3061/discuss-making-redux-state-unaware-that-the-chat-tab-is-always-enabled Generally we might want to add chat to the state, but maybe not as a true, but as a boolean, so that the redux doesn't know about the business-logic-specific fact - that the chat tab is always selected. But that also requires some more changes |