Page MenuHomePhabricator
Differential D6922

Permanently enable rescind and visible notifications processing via NotificationService
ClosedPublic
Actions

Authored by marcin on Mar 1 2023, 4:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 4:04 AM
Unknown Object (File)
Fri, Apr 12, 4:04 AM
Unknown Object (File)
Fri, Apr 12, 4:04 AM
Unknown Object (File)
Fri, Apr 12, 4:04 AM
Unknown Object (File)
Fri, Apr 12, 4:04 AM
Unknown Object (File)
Fri, Apr 12, 4:03 AM
Unknown Object (File)
Fri, Apr 12, 3:51 AM
Unknown Object (File)
Mar 28 2024, 9:04 PM
View All 51 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM523b192eaa62: Permanently enable rescind and visible notifications processing via…
Summary

This differential removed codeVersion > 1000 condition so that visible notifications and rescinds processing is done in NotificationService.

IMPORTANT: I oblige myself to add suitable check against specific code version before landing. Ths code version in the check will be <current native code version + 2>.
Test Plan

Repeat test plan for the entire stack (excluding first differential) whthout the need to change anything in keyserver.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-3074
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Mar 1 2023, 4:54 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 1 2023, 4:54 AM
marcin added a parent revision: D6921: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses on app start..Mar 1 2023, 4:54 AM
Harbormaster completed remote builds in B17039: Diff 23334.Mar 1 2023, 5:09 AM
marcin requested review of this revision.Mar 1 2023, 5:09 AM
marcin updated this revision to Diff 23335.Mar 1 2023, 5:30 AM

Remove rescind handling from AppDelegate.

marcin updated this revision to Diff 23336.Mar 1 2023, 5:33 AM

Remove unread constant

Harbormaster completed remote builds in B17040: Diff 23335.Mar 1 2023, 5:45 AM
Harbormaster completed remote builds in B17041: Diff 23336.Mar 1 2023, 5:47 AM
ashoat added inline comments.Mar 2 2023, 7:24 AM
native/ios/Comm/AppDelegate.mm
190–210

Exciting to see this deleted!!

atul accepted this revision.Mar 9 2023, 10:16 AM
This revision is now accepted and ready to land.Mar 9 2023, 10:16 AM
marcin updated this revision to Diff 23759.Mar 15 2023, 7:10 AM

Rebase before landing. Add check for code version

Harbormaster completed remote builds in B17348: Diff 23759.Mar 15 2023, 7:28 AM
Closed by commit rCOMM523b192eaa62: Permanently enable rescind and visible notifications processing via… (authored by marcin). · Explain WhyMar 15 2023, 7:45 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM523b192eaa62: Permanently enable rescind and visible notifications processing via….

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
2 lines
6 lines
native/
ios/
Comm/
33 lines

Diff 23336

View Options

keyserver/src/push/rescind.js

Loading...
View Options

keyserver/src/push/send.js

Loading...
View Options

native/ios/Comm/AppDelegate.mm

Loading...