[identity] some small fixes
ClosedPublic
Actions

Authored by varun on Mar 2 2023, 6:53 PM.

Details

Reviewers

• jon
bartek
tomek

Commits

rCOMMc3174b1ed019: [identity] some small fixes

Summary

remove a couple clones of the database client, use tokio spawn to catch errors in streaming RPCs, remove use of unwrap

Test Plan

tested the existing RPCs and errors like client disconnects were handled more gracefully (no broken pipe errors)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Mar 2 2023, 6:53 PM

Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 2 2023, 6:53 PM

varun added a child revision: D6914: [keyserver] add loginUserPake function to rust-node-addon, call it from loginResponder in js.Mar 2 2023, 6:56 PM

Harbormaster completed remote builds in B17079: Diff 23384.Mar 2 2023, 7:09 PM

varun requested review of this revision.Mar 2 2023, 7:09 PM

• jon accepted this revision.Mar 2 2023, 10:28 PM

This revision is now accepted and ready to land.Mar 2 2023, 10:28 PM

Closed by commit rCOMMc3174b1ed019: [identity] some small fixes (authored by varun). · Explain WhyMar 3 2023, 12:53 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMc3174b1ed019: [identity] some small fixes.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

service.rs

109 lines

service/

4 lines

registration.rs

2 lines

Diff 23384

View Options

services/identity/src/service.rs

View Options

services/identity/src/service/login.rs

View Options

services/identity/src/service/registration.rs

[identity] some small fixesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 23384

services/identity/src/service.rs

services/identity/src/service/login.rs

services/identity/src/service/registration.rs

[identity] some small fixes
ClosedPublic
Actions

Revision Contents
Changeset List