Paths

Table of Contentst

[keyserver] call Identity service RegisterUser RPC from createAccount
ClosedPublic
Actions

Authored by varun on Mar 2 2023, 7:02 PM.

Details

Reviewers

• jon
ashoat
bartek
atul

Commits

rCOMM51cb23048180: [keyserver] call Identity service RegisterUser RPC from createAccount

Summary

fixed the registerUser function type in lib
call registerUser from createAccount if the signedIdentityKeysBlob is present

Depends on D6914

Test Plan

first, I created a new account on mobile with username/password; saw that the correct user data was in the user and token tables in DDB
second, logged out and back in on web; nothing changed in users table
third, logged in on web, saw that a new device was added to the users table and a new access token was added to the tokens table

also tested that if we're disconnected from the identity service for whatever reason, nothing crashes on the keyserver

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Mar 2 2023, 7:02 PM

Herald added subscribers: atul, tomek. · View Herald TranscriptMar 2 2023, 7:02 PM

Harbormaster completed remote builds in B17081: Diff 23386.Mar 2 2023, 7:17 PM

varun requested review of this revision.Mar 2 2023, 7:17 PM

varun added a child revision: D6942: [identity] change siwe signature type.Mar 2 2023, 8:04 PM

I don't see anything I feel strongly about, I'll keep on the queue for others

ashoat accepted this revision.Mar 3 2023, 8:59 AM

ashoat added inline comments.

keyserver/src/creators/account-creator.js
125
192	We could initiate this call earlier so that it has more time to complete, but I'm not sure how long it takes. Right now you're waiting for several `await`s before you start this call, but you could start it before any of the `await`s to give it more time
lib/types/rust-binding-types.js
21	I think it'd be better to be more specific – see this comment on D6914

This revision is now accepted and ready to land.Mar 3 2023, 8:59 AM

ashoat mentioned this in D6946: [keyserver] double-write to identity service from siweAuthResponder callpoint.Mar 3 2023, 9:00 AM

ashoat added a reviewer: atul.

address feedback

Harbormaster completed remote builds in B17099: Diff 23412.Mar 3 2023, 12:11 PM

varun added inline comments.Mar 3 2023, 12:25 PM

keyserver/src/creators/account-creator.js
192	makes sense
lib/types/rust-binding-types.js
21	linked linear task on the other diff, will follow up on this before EOD

Closed by commit rCOMM51cb23048180: [keyserver] call Identity service RegisterUser RPC from createAccount (authored by varun). · Explain WhyMar 3 2023, 12:29 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM51cb23048180: [keyserver] call Identity service RegisterUser RPC from createAccount.

ashoat added inline comments.Mar 3 2023, 12:38 PM

keyserver/src/creators/account-creator.js
127 ↗	(On Diff #23424)	@jon's approach in D6944 is actually probably better... I should've suggested that. Basically we don't need to wait on `getRustAPI()` at all since we're wrapping the call with `handleAsyncPromise`. So instead we can construct a promise that composes `getRustAPI()` with the later call

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

account-creator.js

30 lines

lib/

types/

rust-binding-types.js

4 lines

Diff 23386

View Options

keyserver/src/creators/account-creator.js