Page MenuHomePhabricator
Differential D6946

[keyserver] double-write to identity service from siweAuthResponder callpoint
ClosedPublic
Actions

Authored by varun on Mar 3 2023, 12:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 26, 9:10 AM
Unknown Object (File)
Sat, Oct 19, 9:30 PM
Unknown Object (File)
Sat, Oct 19, 5:03 PM
Unknown Object (File)
Fri, Oct 18, 5:44 PM
Unknown Object (File)
Fri, Oct 18, 5:44 PM
Unknown Object (File)
Fri, Oct 18, 9:56 AM
Unknown Object (File)
Oct 10 2024, 6:09 AM
Unknown Object (File)
Oct 9 2024, 10:02 PM
View All Files
Subscribers
atul
tomek

Details

Reviewers
ashoat
• jon
bartek
atul
Commits
rCOMM930a4c1916ae: [keyserver] double-write to identity service from siweAuthResponder callpoint
Summary

we should double-write siwe account creations and logins to the identity service using the loginUserWallet function in the rust-node-addon.

Depends on D6945

Test Plan

logged in on web with my rainbow wallet, saw that the same user data was written to MariaDB and DynamoDB

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Mar 3 2023, 12:50 AM
Herald added subscribers: atul, tomek. · View Herald TranscriptMar 3 2023, 12:50 AM
Harbormaster completed remote builds in B17089: Diff 23395.Mar 3 2023, 1:05 AM
varun requested review of this revision.Mar 3 2023, 1:05 AM
ashoat accepted this revision.Mar 3 2023, 9:00 AM
ashoat added inline comments.
keyserver/src/responders/user-responders.js
569

Same comment as in D6941

This revision is now accepted and ready to land.Mar 3 2023, 9:00 AM
ashoat added a reviewer: atul.Mar 3 2023, 9:01 AM
ashoat added inline comments.Mar 3 2023, 12:38 PM
keyserver/src/responders/user-responders.js
569

@jon's approach in D6944 is actually probably better... I should've suggested that. Basically we don't need to wait on getRustAPI() at all since we're wrapping the call with handleAsyncPromise. So instead we can construct a promise that composes getRustAPI() with the later call

varun updated this revision to Diff 23428.Mar 3 2023, 1:28 PM

address feedback

This revision was landed with ongoing or failed builds.Mar 3 2023, 1:29 PM
Closed by commit rCOMM930a4c1916ae: [keyserver] double-write to identity service from siweAuthResponder callpoint (authored by varun). · Explain Why
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM930a4c1916ae: [keyserver] double-write to identity service from siweAuthResponder callpoint.
ashoat added inline comments.Mar 3 2023, 1:30 PM
keyserver/src/responders/user-responders.js
575 ↗(On Diff #23428)

This should be awaited though, no? If we don't await, I think there's a risk of an unhandled promise exception from Node

Harbormaster completed remote builds in B17105: Diff 23428.Mar 3 2023, 1:44 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
17 lines

Diff 23395

View Options

keyserver/src/responders/user-responders.js

Loading...