Page MenuHomePhabricator

[keyserver] Only set sidebarCreation flag for the first message in the sidebar
ClosedPublic

Authored by ashoat on Mar 2 2023, 2:01 PM.
Tags
None
Referenced Files
F3398199: D6932.id23413.diff
Sun, Dec 1, 9:40 PM
F3397836: D6932.diff
Sun, Dec 1, 7:40 PM
Unknown Object (File)
Oct 27 2024, 2:33 PM
Unknown Object (File)
Oct 19 2024, 5:02 PM
Unknown Object (File)
Oct 19 2024, 5:02 PM
Unknown Object (File)
Oct 19 2024, 5:02 PM
Unknown Object (File)
Oct 19 2024, 5:02 PM
Unknown Object (File)
Oct 11 2024, 7:01 AM
Subscribers

Details

Summary

When I say "first message" in the commit title, I really mean the third message, as each sidebar starts with a SIDEBAR_SOURCE and then a CREATE_SIDEBAR.

Check out the code comment for an explanation as to why we're doing this.

Test Plan

Force sidebarCreation to true on the client for all text messages, and confirm that it is ignored when invalid

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable