Page MenuHomePhabricator
Differential D6936

[keyserver][lib] Allow notificationTexts to return null
ClosedPublic
Actions

Authored by ashoat on Mar 2 2023, 2:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 2:33 PM
Unknown Object (File)
Sat, Oct 19, 5:03 PM
Unknown Object (File)
Fri, Oct 18, 5:44 PM
Unknown Object (File)
Fri, Oct 18, 9:51 AM
Unknown Object (File)
Fri, Oct 18, 9:51 AM
Unknown Object (File)
Fri, Oct 18, 9:51 AM
Unknown Object (File)
Sep 29 2024, 10:03 PM
Unknown Object (File)
Sep 27 2024, 8:52 PM
View All Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMMcd53fa783f4a: [keyserver][lib] Allow notificationTexts to return null
Summary

In order to decide whether to send a notif, we may need more information than we have at the time generatesNotifs is called.

More concretely: in a later diff, we'll need to make a decision on whether to send a notif based on the contents of an earlier message with the same collapse key.

Depends on D6935

Test Plan

Flow, and tested in combination with the next diffs to confirm that getting @-tagged in a message that triggers the creation of a sidebar will update the SIDEBAR_CREATION notif
to be suffixed with "and tagged you"

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 2 2023, 2:05 PM
Herald added a subscriber: tomek. · View Herald TranscriptMar 2 2023, 2:05 PM
ashoat added a child revision: D6937: [lib] Extract notifTextsForSidebarCreation.Mar 2 2023, 2:05 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2023, 2:19 PM
Harbormaster failed remote builds in B17070: Diff 23372!
ashoat updated this revision to Diff 23380.Mar 2 2023, 3:35 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2023, 3:45 PM
Harbormaster failed remote builds in B17076: Diff 23380!
Harbormaster completed remote builds in B17076: Diff 23380.Mar 2 2023, 3:51 PM
ashoat requested review of this revision.Mar 2 2023, 3:51 PM
atul accepted this revision.Mar 3 2023, 11:01 AM
This revision is now accepted and ready to land.Mar 3 2023, 11:01 AM
Closed by commit rCOMMcd53fa783f4a: [keyserver][lib] Allow notificationTexts to return null (authored by ashoat). · Explain WhyMar 3 2023, 12:11 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMcd53fa783f4a: [keyserver][lib] Allow notificationTexts to return null.

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
3 lines
lib/
shared/
messages/
4 lines
10 lines

Diff 23416

View Options

keyserver/src/push/send.js

Loading...
View Options

lib/shared/messages/message-spec.js

Loading...
View Options

lib/shared/notif-utils.js

Loading...