Page MenuHomePhabricator

[lib][keyserver] Update reaction permission checks to check REACT_TO_MESSAGE
ClosedPublic

Authored by ashoat on Mar 14 2023, 8:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 10, 7:47 AM
Unknown Object (File)
Tue, May 7, 12:17 PM
Unknown Object (File)
Sun, May 5, 6:35 AM
Unknown Object (File)
Fri, May 3, 2:51 AM
Unknown Object (File)
Sat, Apr 27, 6:54 AM
Unknown Object (File)
Wed, Apr 24, 9:12 PM
Unknown Object (File)
Apr 12 2024, 4:04 AM
Unknown Object (File)
Apr 12 2024, 4:04 AM
Subscribers

Details

Summary

In the last diff, I introduced a new threadPermissions constant for reactions.

In this diff, I update permission checks on the keyserver and client to check this new constant.

Depends on D7073

Test Plan

I tested this in combination with the next diff by:

  1. Running the migration by restarting the keyserver after introducing it and making sure it runs successfully
  2. Testing reacting as a member (non-admin) to a message in a COMMUNITY_ANNOUNCEMENT_ROOT community root. I don't have permission to send messages, but I can react on both native and web.

I didn't need to log out / back in on native, which indicates the the updatesTypes.UPDATE_THREAD updates were propagated correctly by the migration

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable