Page MenuHomePhabricator

[lib][keyserver] Introduce new threadPermissions types for reactions

Authored by ashoat on Tue, Mar 14, 8:07 PM.
Referenced Files
F445758: D7073.id23779.diff
Sun, Mar 26, 4:15 AM
Unknown Object (File)
Fri, Mar 24, 6:11 AM
Unknown Object (File)
Mon, Mar 20, 11:59 PM
Unknown Object (File)
Sat, Mar 18, 5:13 PM
Unknown Object (File)
Thu, Mar 16, 2:31 AM
Unknown Object (File)
Thu, Mar 16, 2:31 AM
Unknown Object (File)
Wed, Mar 15, 8:44 PM



I want to allow people to react in announcement channels even though they can't send messages, so I'm introducing a new threadPermissions type.

This diff introduces the type, adds it to all roles except GENESIS members, and adds a new migration to populate it.

Test Plan

I tested this in combination with the next diff by:

  1. Running the migration by restarting the keyserver after introducing it and making sure it runs successfully
  2. Testing reacting as a member (non-admin) to a message in a COMMUNITY_ANNOUNCEMENT_ROOT community root. I don't have permission to send messages, but I can react on both native and web. I didn't need to log out / back in on native, which indicates the the updatesTypes.UPDATE_THREAD updates were propagated correctly by the migration

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable