Updated the message list header based on how it looks in the figma design doc:
{F445548}
Android was already doing this, so I just needed to remove some conditional logic causing iOS to look different.
Depends on D7132
Details
Details
Please check out these screenshots to see the changes I made:
Before:
iOS:
Android:
After (pre avatars world):
iOS:
Android:
After (post-avatars world):
iOS:
Android:
Search:
iOS:
Android:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/chat/message-list-header-title.react.js | ||
|---|---|---|
| 67 ↗ | (On Diff #23970) | Why !isSearchEmpty? |
| 68 ↗ | (On Diff #23970) | You appear to be using the avatar to balance out the icon, but I think that will only appear properly centered if the two components are exactly the same width. Is that the case? If so, you should avoid having two variables (avatar and fakeIcon), where only one is rendered at a time and they have some overlap in their function. Instead, we should assign to one variable, have an if-else-if structure for setting that variable, and have a comment explaining why we don't need fakeIcon if we have avatar, and that the two are exactly the same width. If the two aren't the same width, we'll need to think critically about how we make this work and how it's designed. Can you link the Figma designs? |
| native/chat/message-list-header-title.react.js | ||
|---|---|---|
| 67 ↗ | (On Diff #23970) | This prevents rendering when an avatar in MessageListHeaderTitle when the user is trying to create a new chat thread  |
| 68 ↗ | (On Diff #23970) | Double checked the figma design and we should actually be left aligning everything (what we do for android today). This was a screw up on my end from not being careful and doing something without double-checking. Will update accordingly. |
| native/chat/chat.react.js | ||
|---|---|---|
| 237 ↗ | (On Diff #24142) | Can you check with Ted to confirm that we still want to center the header title in the chat creation design? |
| native/chat/chat.react.js | ||
|---|---|---|
| 237 ↗ | (On Diff #24142) | Just spoke to Ted IRL and he says to center the header title in chat creation |