Page MenuHomePhabricator
Differential D7258

[identity] config for LocalStack
ClosedPublic
Actions

Authored by varun on Mar 30 2023, 12:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 24, 5:17 PM
Unknown Object (File)
Tue, Apr 8, 2:49 AM
Unknown Object (File)
Mon, Apr 7, 9:53 AM
Unknown Object (File)
Feb 25 2025, 7:15 AM
Unknown Object (File)
Feb 25 2025, 7:15 AM
Unknown Object (File)
Feb 25 2025, 7:15 AM
Unknown Object (File)
Feb 24 2025, 12:28 AM
Unknown Object (File)
Feb 24 2025, 12:28 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMM86ee2981a2e3: [identity] config for LocalStack
Summary

we need to introduce some more config for our DDB client to be able to connect to the LocalStack endpoint.

If the LOCALSTACK_ENDPOINT env var is set, the DDB client will connect to that endpoint instead of the AWS prod endpoint.

Test Plan

called GenerateNonce with the env var set, used AWS cli to confirm that the nonce was added to my LocalStack DDB identity-nonces table
called with the env var unset, and the nonce was added to my actual DDB test table

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Mar 30 2023, 12:32 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 30 2023, 12:32 PM
varun added a parent revision: D7256: [identity] bump aws-config and aws-sdk-dynamodb crate versions.Mar 30 2023, 12:33 PM
Harbormaster completed remote builds in B17843: Diff 24439.Mar 30 2023, 12:48 PM
varun requested review of this revision.Mar 30 2023, 12:48 PM
varun updated this revision to Diff 24441.Mar 30 2023, 12:48 PM

AWS_ENDPOINT -> LOCALSTACK_ENDPOINT

Harbormaster completed remote builds in B17845: Diff 24441.Mar 30 2023, 1:02 PM
varun added a reviewer: bartek.Mar 30 2023, 3:22 PM
bartek accepted this revision.Mar 31 2023, 4:17 AM
This revision is now accepted and ready to land.Mar 31 2023, 4:17 AM
Closed by commit rCOMM86ee2981a2e3: [identity] config for LocalStack (authored by varun). · Explain WhyMar 31 2023, 12:21 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM86ee2981a2e3: [identity] config for LocalStack.
• jon added a comment.Apr 3 2023, 6:56 AM

Looks like i got distracted friday

scripts/source_development_defaults.sh
55

terraform seems to respect this environment variable, I don't think we should change it. Probably just define LOCALSTACK_ENDPOINT in addition to it.

Revision Contents
Changeset List

PathSize
scripts/
2 lines
services/
identity/
src/
19 lines
4 lines
17 lines

Diff 24441

View Options

scripts/source_development_defaults.sh

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines
class ChatThreadList extends React.PureComponent<Props> { class ChatThreadList extends React.PureComponent<Props> {
flatList: ?FlatList<Item>; flatList: ?FlatList<Item>;
constructor(props: Props) { constructor(props: Props) {
super(props); super(props);
} }
componentDidUpdate(prevProps: Props) {
const { searchStatus } = this.props;
const prevSearchStatus = prevProps.searchStatus;
const isActiveOrActivating =
searchStatus === 'active' || searchStatus === 'activating';
const wasActiveOrActivating =
prevSearchStatus === 'active' || prevSearchStatus === 'activating';
if (isActiveOrActivating && !wasActiveOrActivating) {
this.props.searchCancelButtonOpen.setValue(1);
} else if (!isActiveOrActivating && wasActiveOrActivating) {
this.props.searchCancelButtonOpen.setValue(0);
}
const { flatList } = this;
if (!flatList) {
return;
}
if (this.props.searchText !== prevProps.searchText) {
flatList.scrollToOffset({ offset: 0, animated: false });
return;
}
if (searchStatus === 'activating' && prevSearchStatus === 'inactive') {
flatList.scrollToOffset({ offset: 0, animated: true });
}
}
render() { render() {
return this.props.chatThreadList; return this.props.chatThreadList;
} }
flatListRef = (flatList: ?FlatList<Item>) => { flatListRef = (flatList: ?FlatList<Item>) => {
this.flatList = flatList; this.flatList = flatList;
}; };
} }
▲ Show 20 Lines • Show All 412 Lines • ▼ Show 20 Linesfunction ConnectedChatThreadList(props: BaseProps): React.Node {
React.useEffect(() => { React.useEffect(() => {
BackHandler.addEventListener('hardwareBackPress', hardwareBack); BackHandler.addEventListener('hardwareBackPress', hardwareBack);
return () => { return () => {
BackHandler.removeEventListener('hardwareBackPress', hardwareBack); BackHandler.removeEventListener('hardwareBackPress', hardwareBack);
}; };
}, [hardwareBack]); }, [hardwareBack]);
const isActiveOrActivating =
searchStatus === 'active' || searchStatus === 'activating';
React.useEffect(() => {
if (isActiveOrActivating) {
searchCancelButtonOpen.setValue(1);
} else {
searchCancelButtonOpen.setValue(0);
}
}, [isActiveOrActivating, searchCancelButtonOpen]);
React.useEffect(() => {
if (scrollPos.current > 0 && flatListRef.current) {
flatListRef.current.scrollToOffset({ offset: 0, animated: false });
}
}, [searchText]);
const isSearchActivating = searchStatus === 'activating';
React.useEffect(() => {
if (isSearchActivating && scrollPos.current > 0 && flatListRef.current) {
flatListRef.current.scrollToOffset({ offset: 0, animated: true });
}
}, [isSearchActivating]);
return ( return (
<ChatThreadList <ChatThreadList
navigation={navigation} navigation={navigation}
route={route} route={route}
filterThreads={filterThreads} filterThreads={filterThreads}
emptyItem={emptyItem} emptyItem={emptyItem}
searchText={searchText} searchText={searchText}
searchStatus={searchStatus} searchStatus={searchStatus}
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines
View Options

services/identity/src/config.rs

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines
class ChatThreadList extends React.PureComponent<Props> { class ChatThreadList extends React.PureComponent<Props> {
flatList: ?FlatList<Item>; flatList: ?FlatList<Item>;
constructor(props: Props) { constructor(props: Props) {
super(props); super(props);
} }
componentDidUpdate(prevProps: Props) {
const { searchStatus } = this.props;
const prevSearchStatus = prevProps.searchStatus;
const isActiveOrActivating =
searchStatus === 'active' || searchStatus === 'activating';
const wasActiveOrActivating =
prevSearchStatus === 'active' || prevSearchStatus === 'activating';
if (isActiveOrActivating && !wasActiveOrActivating) {
this.props.searchCancelButtonOpen.setValue(1);
} else if (!isActiveOrActivating && wasActiveOrActivating) {
this.props.searchCancelButtonOpen.setValue(0);
}
const { flatList } = this;
if (!flatList) {
return;
}
if (this.props.searchText !== prevProps.searchText) {
flatList.scrollToOffset({ offset: 0, animated: false });
return;
}
if (searchStatus === 'activating' && prevSearchStatus === 'inactive') {
flatList.scrollToOffset({ offset: 0, animated: true });
}
}
render() { render() {
return this.props.chatThreadList; return this.props.chatThreadList;
} }
flatListRef = (flatList: ?FlatList<Item>) => { flatListRef = (flatList: ?FlatList<Item>) => {
this.flatList = flatList; this.flatList = flatList;
}; };
} }
▲ Show 20 Lines • Show All 412 Lines • ▼ Show 20 Linesfunction ConnectedChatThreadList(props: BaseProps): React.Node {
React.useEffect(() => { React.useEffect(() => {
BackHandler.addEventListener('hardwareBackPress', hardwareBack); BackHandler.addEventListener('hardwareBackPress', hardwareBack);
return () => { return () => {
BackHandler.removeEventListener('hardwareBackPress', hardwareBack); BackHandler.removeEventListener('hardwareBackPress', hardwareBack);
}; };
}, [hardwareBack]); }, [hardwareBack]);
const isActiveOrActivating =
searchStatus === 'active' || searchStatus === 'activating';
React.useEffect(() => {
if (isActiveOrActivating) {
searchCancelButtonOpen.setValue(1);
} else {
searchCancelButtonOpen.setValue(0);
}
}, [isActiveOrActivating, searchCancelButtonOpen]);
React.useEffect(() => {
if (scrollPos.current > 0 && flatListRef.current) {
flatListRef.current.scrollToOffset({ offset: 0, animated: false });
}
}, [searchText]);
const isSearchActivating = searchStatus === 'activating';
React.useEffect(() => {
if (isSearchActivating && scrollPos.current > 0 && flatListRef.current) {
flatListRef.current.scrollToOffset({ offset: 0, animated: true });
}
}, [isSearchActivating]);
return ( return (
<ChatThreadList <ChatThreadList
navigation={navigation} navigation={navigation}
route={route} route={route}
filterThreads={filterThreads} filterThreads={filterThreads}
emptyItem={emptyItem} emptyItem={emptyItem}
searchText={searchText} searchText={searchText}
searchStatus={searchStatus} searchStatus={searchStatus}
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines
View Options

services/identity/src/constants.rs

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines
class ChatThreadList extends React.PureComponent<Props> { class ChatThreadList extends React.PureComponent<Props> {
flatList: ?FlatList<Item>; flatList: ?FlatList<Item>;
constructor(props: Props) { constructor(props: Props) {
super(props); super(props);
} }
componentDidUpdate(prevProps: Props) {
const { searchStatus } = this.props;
const prevSearchStatus = prevProps.searchStatus;
const isActiveOrActivating =
searchStatus === 'active' || searchStatus === 'activating';
const wasActiveOrActivating =
prevSearchStatus === 'active' || prevSearchStatus === 'activating';
if (isActiveOrActivating && !wasActiveOrActivating) {
this.props.searchCancelButtonOpen.setValue(1);
} else if (!isActiveOrActivating && wasActiveOrActivating) {
this.props.searchCancelButtonOpen.setValue(0);
}
const { flatList } = this;
if (!flatList) {
return;
}
if (this.props.searchText !== prevProps.searchText) {
flatList.scrollToOffset({ offset: 0, animated: false });
return;
}
if (searchStatus === 'activating' && prevSearchStatus === 'inactive') {
flatList.scrollToOffset({ offset: 0, animated: true });
}
}
render() { render() {
return this.props.chatThreadList; return this.props.chatThreadList;
} }
flatListRef = (flatList: ?FlatList<Item>) => { flatListRef = (flatList: ?FlatList<Item>) => {
this.flatList = flatList; this.flatList = flatList;
}; };
} }
▲ Show 20 Lines • Show All 412 Lines • ▼ Show 20 Linesfunction ConnectedChatThreadList(props: BaseProps): React.Node {
React.useEffect(() => { React.useEffect(() => {
BackHandler.addEventListener('hardwareBackPress', hardwareBack); BackHandler.addEventListener('hardwareBackPress', hardwareBack);
return () => { return () => {
BackHandler.removeEventListener('hardwareBackPress', hardwareBack); BackHandler.removeEventListener('hardwareBackPress', hardwareBack);
}; };
}, [hardwareBack]); }, [hardwareBack]);
const isActiveOrActivating =
searchStatus === 'active' || searchStatus === 'activating';
React.useEffect(() => {
if (isActiveOrActivating) {
searchCancelButtonOpen.setValue(1);
} else {
searchCancelButtonOpen.setValue(0);
}
}, [isActiveOrActivating, searchCancelButtonOpen]);
React.useEffect(() => {
if (scrollPos.current > 0 && flatListRef.current) {
flatListRef.current.scrollToOffset({ offset: 0, animated: false });
}
}, [searchText]);
const isSearchActivating = searchStatus === 'activating';
React.useEffect(() => {
if (isSearchActivating && scrollPos.current > 0 && flatListRef.current) {
flatListRef.current.scrollToOffset({ offset: 0, animated: true });
}
}, [isSearchActivating]);
return ( return (
<ChatThreadList <ChatThreadList
navigation={navigation} navigation={navigation}
route={route} route={route}
filterThreads={filterThreads} filterThreads={filterThreads}
emptyItem={emptyItem} emptyItem={emptyItem}
searchText={searchText} searchText={searchText}
searchStatus={searchStatus} searchStatus={searchStatus}
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines
View Options

services/identity/src/database.rs

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines
class ChatThreadList extends React.PureComponent<Props> { class ChatThreadList extends React.PureComponent<Props> {
flatList: ?FlatList<Item>; flatList: ?FlatList<Item>;
constructor(props: Props) { constructor(props: Props) {
super(props); super(props);
} }
componentDidUpdate(prevProps: Props) {
const { searchStatus } = this.props;
const prevSearchStatus = prevProps.searchStatus;
const isActiveOrActivating =
searchStatus === 'active' || searchStatus === 'activating';
const wasActiveOrActivating =
prevSearchStatus === 'active' || prevSearchStatus === 'activating';
if (isActiveOrActivating && !wasActiveOrActivating) {
this.props.searchCancelButtonOpen.setValue(1);
} else if (!isActiveOrActivating && wasActiveOrActivating) {
this.props.searchCancelButtonOpen.setValue(0);
}
const { flatList } = this;
if (!flatList) {
return;
}
if (this.props.searchText !== prevProps.searchText) {
flatList.scrollToOffset({ offset: 0, animated: false });
return;
}
if (searchStatus === 'activating' && prevSearchStatus === 'inactive') {
flatList.scrollToOffset({ offset: 0, animated: true });
}
}
render() { render() {
return this.props.chatThreadList; return this.props.chatThreadList;
} }
flatListRef = (flatList: ?FlatList<Item>) => { flatListRef = (flatList: ?FlatList<Item>) => {
this.flatList = flatList; this.flatList = flatList;
}; };
} }
▲ Show 20 Lines • Show All 412 Lines • ▼ Show 20 Linesfunction ConnectedChatThreadList(props: BaseProps): React.Node {
React.useEffect(() => { React.useEffect(() => {
BackHandler.addEventListener('hardwareBackPress', hardwareBack); BackHandler.addEventListener('hardwareBackPress', hardwareBack);
return () => { return () => {
BackHandler.removeEventListener('hardwareBackPress', hardwareBack); BackHandler.removeEventListener('hardwareBackPress', hardwareBack);
}; };
}, [hardwareBack]); }, [hardwareBack]);
const isActiveOrActivating =
searchStatus === 'active' || searchStatus === 'activating';
React.useEffect(() => {
if (isActiveOrActivating) {
searchCancelButtonOpen.setValue(1);
} else {
searchCancelButtonOpen.setValue(0);
}
}, [isActiveOrActivating, searchCancelButtonOpen]);
React.useEffect(() => {
if (scrollPos.current > 0 && flatListRef.current) {
flatListRef.current.scrollToOffset({ offset: 0, animated: false });
}
}, [searchText]);
const isSearchActivating = searchStatus === 'activating';
React.useEffect(() => {
if (isSearchActivating && scrollPos.current > 0 && flatListRef.current) {
flatListRef.current.scrollToOffset({ offset: 0, animated: true });
}
}, [isSearchActivating]);
return ( return (
<ChatThreadList <ChatThreadList
navigation={navigation} navigation={navigation}
route={route} route={route}
filterThreads={filterThreads} filterThreads={filterThreads}
emptyItem={emptyItem} emptyItem={emptyItem}
searchText={searchText} searchText={searchText}
searchStatus={searchStatus} searchStatus={searchStatus}
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines