[native] update comm icon pack
ClosedPublic
Actions

Authored by ginsu on Apr 16 2023, 11:21 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMMd36c0d50101f: [native] update comm icon pack

Summary

This diff adds the following new icons to the CommIcon pack: pin, unpin, pin-mirror and etherium-outline. These changes were copy and pasted from files given to me by Ted.

Test Plan

Please see the screenshots to see what the following icons look like

pin:

Screenshot 2023-04-17 at 2.12.36 AM.png (184×196 px, 11 KB)

pin-mirror:

Screenshot 2023-04-17 at 2.13.15 AM.png (180×204 px, 11 KB)

unpin:

Screenshot 2023-04-17 at 2.12.27 AM.png (214×220 px, 13 KB)

etherium-outline:

Screenshot 2023-04-17 at 2.13.59 AM.png (178×202 px, 11 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Apr 16 2023, 11:21 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 16 2023, 11:21 PM

ginsu edited the test plan for this revision. (Show Details)Apr 16 2023, 11:22 PM

ginsu added reviewers: ashoat, atul.

ginsu attached a referenced file: F489848: Screenshot 2023-04-17 at 2.13.59 AM.png. (Show Details)

ginsu attached a referenced file: F489847: Screenshot 2023-04-17 at 2.12.27 AM.png. (Show Details)

ginsu attached a referenced file: F489846: Screenshot 2023-04-17 at 2.13.15 AM.png. (Show Details)

ginsu attached a referenced file: F489845: Screenshot 2023-04-17 at 2.12.36 AM.png. (Show Details)

ginsu edited the summary of this revision. (Show Details)

ginsu added a subscriber: rohan.

Harbormaster completed remote builds in B18395: Diff 25203.Apr 16 2023, 11:39 PM

ginsu requested review of this revision.Apr 16 2023, 11:39 PM

ginsu added a child revision: D7462: [native] introduce use ens avatar option to edit avatar.Apr 17 2023, 12:39 AM

Thanks for this!

Not sure familiar with this stuff – would be great if @atul could take a look

Could you share the source SVGs via DropBox or Google Drive or something?

This revision is now accepted and ready to land.Apr 17 2023, 6:30 AM

Just added Ginsu to Dropbox

Could you share the source SVGs via DropBox or Google Drive or something?

Created a new folder called Comm Icons (Apr 2023) in the team dropbox which has all the icons in this diff. Going to land this diff soon, but lmk if there is a better way to share the source SVGs in Dropbox

https://www.dropbox.com/scl/fo/965l3r3j6gon9pfyn9791/h?dl=0&rlkey=fka6jx84nvb3o1nk1t9za2qrj

Closed by commit rCOMMd36c0d50101f: [native] update comm icon pack (authored by ginsu). · Explain WhyApr 17 2023, 8:32 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMd36c0d50101f: [native] update comm icon pack.