Paths

Table of Contentst

-
native/redux/
-
redux/
-
persist.js

[native] migrate message store threads to SQLite
ClosedPublic
Actions

Authored by kamil on Apr 17 2023, 11:18 AM.

Details

Reviewers

tomek
marcin

Commits

rCOMM0b8d068678e7: [native] migrate message store threads to SQLite

Summary

Migrating rehydrated store to SQLite database.

Depends on D7470

Test Plan

Check if migration succeeded:

And if database content equals redux state (from redux-devtools)

Diff Detail

Repository

rCOMM Comm

Branch

land-rp

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Apr 17 2023, 11:18 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 17 2023, 11:18 AM

kamil added a child revision: D7472: [CommCoreModule] implement logic to get message store threads from SQLite.Apr 17 2023, 11:33 AM

kamil edited the test plan for this revision. (Show Details)Apr 17 2023, 11:35 AM

Harbormaster completed remote builds in B18416: Diff 25227.Apr 17 2023, 11:36 AM

kamil published this revision for review.Apr 18 2023, 2:56 AM

tomek accepted this revision.Apr 20 2023, 7:48 AM

tomek added inline comments.

native/redux/persist.js
510 ↗	(On Diff #25227)	In other migrations that populated the db, we were adding a remove operation as the first one. Should we something similar here?

This revision is now accepted and ready to land.Apr 20 2023, 7:48 AM

remove operation

native/redux/persist.js
510 ↗	(On Diff #25227)	I think this is not needed as I wanted to land the entire stack at once but I'll add this to match the convention

Harbormaster completed remote builds in B18613: Diff 25499.Apr 21 2023, 2:52 AM

Closed by commit rCOMM0b8d068678e7: [native] migrate message store threads to SQLite (authored by kamil). · Explain WhyApr 21 2023, 3:11 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM0b8d068678e7: [native] migrate message store threads to SQLite.

Revision Contents
Changeset List

Path

Size

native/

redux/

persist.js

26 lines

Diff 25499

View Options

native/redux/persist.js

// @flow		// @flow

import _memoize from 'lodash/memoize.js';		import _memoize from 'lodash/memoize.js';
import { createSelector } from 'reselect';		import { createSelector } from 'reselect';

import {		import {
getAvatarForUser,		getAvatarForUser,
getRandomDefaultEmojiAvatar,		getRandomDefaultEmojiAvatar,
} from '../shared/avatar-utils.js';		} from '../shared/avatar-utils.js';
import SearchIndex from '../shared/search-index.js';		import SearchIndex from '../shared/search-index.js';
import SentencePrefixSearchIndex from '../shared/sentence-prefix-search-index.js';		import SentencePrefixSearchIndex from '../shared/sentence-prefix-search-index.js';
import { getSingleOtherUser } from '../shared/thread-utils.js';		import { getSingleOtherUser } from '../shared/thread-utils.js';
import type { ClientEmojiAvatar } from '../types/avatar-types';		import type { ClientEmojiAvatar } from '../types/avatar-types';
		import type { MinimallyEncodedRawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js';		import type { BaseAppState } from '../types/redux-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js';		import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadTypes } from '../types/thread-types-enum.js';		import { threadTypes } from '../types/thread-types-enum.js';
import type {		import type {
LegacyRawThreadInfo,		LegacyRawThreadInfo,
LegacyRelativeMemberInfo,
RelativeMemberInfo,		RelativeMemberInfo,
RawThreadInfos,		RawThreadInfos,
} from '../types/thread-types.js';		} from '../types/thread-types.js';
import type {		import type {
UserInfos,		UserInfos,
RelativeUserInfo,		RelativeUserInfo,
AccountUserInfo,		AccountUserInfo,
CurrentUserInfo,		CurrentUserInfo,
Show All 21 Lines	if (userID === viewerID) {
username,		username,
isViewer: false,		isViewer: false,
});		});
}		}
}		}
return relativeUserInfos;		return relativeUserInfos;
}		}

function getRelativeMemberInfos(		type ExtractArrayParam = <T>(arr: $ReadOnlyArray<T>) => T;
threadInfo: ?LegacyRawThreadInfo,
		function getRelativeMemberInfos<
		TI: MinimallyEncodedRawThreadInfo \| LegacyRawThreadInfo,
		>(
		threadInfo: ?TI,
currentUserID: ?string,		currentUserID: ?string,
userInfos: UserInfos,		userInfos: UserInfos,
): $ReadOnlyArray<LegacyRelativeMemberInfo> {		): $ReadOnlyArray<
const relativeMemberInfos = [];		$ReadOnly<{
		...$Call<ExtractArrayParam, $PropertyType<TI, 'members'>>,
		+username: ?string,
		+isViewer: boolean,
		}>,
		> {
		const relativeMemberInfos: Array<
		$ReadOnly<{
		...$Call<ExtractArrayParam, $PropertyType<TI, 'members'>>,
		+username: ?string,
		+isViewer: boolean,
		}>,
		> = [];
if (!threadInfo) {		if (!threadInfo) {
return relativeMemberInfos;		return relativeMemberInfos;
}		}
const memberInfos = threadInfo.members;		const memberInfos = threadInfo.members;
for (const memberInfo of memberInfos) {		for (const memberInfoInput of memberInfos) {
		const memberInfo: $Call<
		ExtractArrayParam,
		$PropertyType<TI, 'members'>,
		> = memberInfoInput;
if (!memberInfo.role) {		if (!memberInfo.role) {
continue;		continue;
}		}
const username = userInfos[memberInfo.id]		const username: ?string = userInfos[memberInfo.id]
? userInfos[memberInfo.id].username		? userInfos[memberInfo.id].username
: null;		: null;
if (memberInfo.id === currentUserID) {		const isViewer: boolean = memberInfo.id === currentUserID;
relativeMemberInfos.unshift({		const relativeMemberInfo: $ReadOnly<{
		...$Call<ExtractArrayParam, $PropertyType<TI, 'members'>>,
		+username: ?string,
		+isViewer: boolean,
		}> = {
...memberInfo,		...memberInfo,
username,		username,
isViewer: true,		isViewer,
});		};
		if (isViewer) {
		relativeMemberInfos.unshift(relativeMemberInfo);
} else {		} else {
relativeMemberInfos.push({		relativeMemberInfos.push(relativeMemberInfo);
...memberInfo,
username,
isViewer: false,
});
}		}
}		}
return relativeMemberInfos;		return relativeMemberInfos;
}		}

const emptyArray: $ReadOnlyArray<LegacyRelativeMemberInfo> = [];		const emptyArray: $ReadOnlyArray<RelativeMemberInfo> = [];

// Includes current user at the start		// Includes current user at the start
const baseRelativeMemberInfoSelectorForMembersOfThread: (		const baseRelativeMemberInfoSelectorForMembersOfThread: (
threadID: ?string,		threadID: ?string,
) => (state: BaseAppState<>) => $ReadOnlyArray<LegacyRelativeMemberInfo> = (		) => (state: BaseAppState<>) => $ReadOnlyArray<RelativeMemberInfo> = (
threadID: ?string,		threadID: ?string,
) => {		) => {
if (!threadID) {		if (!threadID) {
return () => emptyArray;		return () => emptyArray;
}		}
return createSelector(		return createSelector(
(state: BaseAppState<>) => state.threadStore.threadInfos[threadID],		(state: BaseAppState<>) => state.threadStore.threadInfos[threadID],
(state: BaseAppState<>) =>		(state: BaseAppState<>) =>
▲ Show 20 Lines • Show All 149 Lines • Show Last 20 Lines

[native] migrate message store threads to SQLiteClosedPublicActions