Page MenuHomePhabricator
Differential D7597

[native] Add button to KeyserverSelection
ClosedPublic
Actions

Authored by ashoat on Apr 24 2023, 5:35 PM.
Tags
None
Referenced Files
F3174885: D7597.id25789.diff
Thu, Nov 7, 6:47 PM
Unknown Object (File)
Wed, Nov 6, 11:42 AM
Unknown Object (File)
Wed, Oct 23, 4:54 AM
Unknown Object (File)
Fri, Oct 11, 11:50 PM
Unknown Object (File)
Fri, Oct 11, 11:50 PM
Unknown Object (File)
Fri, Oct 11, 11:50 PM
Unknown Object (File)
Fri, Oct 11, 11:50 PM
Unknown Object (File)
Fri, Oct 11, 11:40 PM
View All 88 Files
Subscribers
tomek

Details

Reviewers
ginsu
atul
Commits
rCOMM4f0be980351c: [native] Add button to KeyserverSelection
Summary

Introduces a new RegistrationButton component and adds it to KeyserverSelection. See designs

Depends on D7593

Test Plan

Screenshot 2023-04-24 at 8.34.37 PM.png (1×1 px, 793 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Apr 24 2023, 5:35 PM
Herald added a subscriber: tomek. · View Herald TranscriptApr 24 2023, 5:35 PM
ashoat added a child revision: D7598: [native] Position RegistrationButton at the bottom of KeyserverSelection.Apr 24 2023, 5:36 PM
ashoat added inline comments.Apr 24 2023, 5:42 PM
native/components/button.react.js
25

This change is unrelated. * is the same as any in modern versions of Flow. () => mixed is the right type here, and it introduces no errors

ashoat edited the test plan for this revision. (Show Details)Apr 24 2023, 5:43 PM
Harbormaster completed remote builds in B18720: Diff 25633.Apr 24 2023, 5:53 PM
ashoat requested review of this revision.Apr 24 2023, 5:53 PM
ashoat updated this revision to Diff 25717.Apr 25 2023, 2:04 PM

Rebase

atul accepted this revision.Apr 25 2023, 2:08 PM
This revision is now accepted and ready to land.Apr 25 2023, 2:08 PM
Harbormaster completed remote builds in B18770: Diff 25717.Apr 25 2023, 2:22 PM
Closed by commit rCOMM4f0be980351c: [native] Add button to KeyserverSelection (authored by ashoat). · Explain WhyApr 26 2023, 1:23 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM4f0be980351c: [native] Add button to KeyserverSelection.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
4 lines
36 lines
components/
2 lines

Diff 25633

View Options

native/account/registration/keyserver-selection.react.js

Loading...
View Options

native/account/registration/registration-button.react.js

Loading...
View Options

native/components/button.react.js

Loading...