Page MenuHomePhabricator

[native] Position RegistrationButton at the bottom of KeyserverSelection
ClosedPublic

Authored by ashoat on Apr 24 2023, 5:36 PM.
Tags
None
Referenced Files
F2752795: D7598.id25718.diff
Wed, Sep 18, 4:21 PM
F2752781: D7598.id25790.diff
Wed, Sep 18, 4:18 PM
F2737579: D7598.id25790.diff
Tue, Sep 17, 6:58 PM
F2737578: D7598.id25718.diff
Tue, Sep 17, 6:58 PM
F2737577: D7598.id25634.diff
Tue, Sep 17, 6:58 PM
F2737519: D7598.id.diff
Tue, Sep 17, 6:57 PM
Unknown Object (File)
Mon, Sep 16, 2:13 AM
Unknown Object (File)
Mon, Sep 2, 3:50 PM
Subscribers

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

As of my most recent updates to D7593, the RegistrationContainer now handles scrolling, so we now need to wrap it with a container View.

Two opinionated things I did here:

  1. I opted to leave the padding in RegistrationContainer inside of moving it to the parent View, since I figured it would be good to have that extra vertical padding inside the ScrollView. I could separate the vertical padding and horizontal padding if desired, with the horizontal padding applied by the parent component but the vertical padding applied by the RegistrationContainer
  2. Decided to leave the RegistrationContainer changes here, even though they're no longer used. Figured it might be used in other cases. Can remove it (or separate into another diff) if desired
This revision is now accepted and ready to land.Apr 26 2023, 1:14 PM