Page MenuHomePhabricator
Differential D7599

[native] Add SafeAreaView to RegistrationContainer
ClosedPublic
Actions

Authored by ashoat on Apr 24 2023, 5:41 PM.
Tags
None
Referenced Files
F2752681: D7599.id25635.diff
Wed, Sep 18, 4:07 PM
F2737582: D7599.id25791.diff
Tue, Sep 17, 6:58 PM
F2737581: D7599.id25719.diff
Tue, Sep 17, 6:58 PM
F2737580: D7599.id25635.diff
Tue, Sep 17, 6:58 PM
F2737521: D7599.id.diff
Tue, Sep 17, 6:57 PM
Unknown Object (File)
Mon, Sep 16, 2:03 AM
Unknown Object (File)
Mon, Sep 2, 3:50 PM
Unknown Object (File)
Sat, Aug 31, 6:14 AM
View All 68 Files
Subscribers
tomek

Details

Reviewers
ginsu
atul
Commits
rCOMMfd6dcca13669: [native] Add SafeAreaView to RegistrationContainer
Summary

See designs

Depends on D7598

Test Plan
beforeafter
ios
Screenshot 2023-04-24 at 8.35.43 PM.png (1×1 px, 793 KB)
Screenshot 2023-04-24 at 8.36.40 PM.png (1×1 px, 793 KB)
android
Screenshot 2023-04-24 at 8.41.29 PM.png (2×1 px, 519 KB)
Screenshot 2023-04-24 at 8.41.12 PM.png (2×1 px, 519 KB)

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/registration
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Apr 24 2023, 5:41 PM
Herald added a subscriber: tomek. · View Herald TranscriptApr 24 2023, 5:41 PM
ashoat edited the test plan for this revision. (Show Details)Apr 24 2023, 5:45 PM
Harbormaster completed remote builds in B18722: Diff 25635.Apr 24 2023, 5:59 PM
ashoat requested review of this revision.Apr 24 2023, 5:59 PM
atul attached a referenced file: F506276: Screenshot 2023-04-24 at 8.35.43 PM.png. (Show Details)Apr 25 2023, 10:43 AM
ashoat mentioned this in D7593: [native] Make RegistrationContainer scrollable.Apr 25 2023, 2:03 PM
ashoat updated this revision to Diff 25719.Apr 25 2023, 2:09 PM

I was seeing an issue where the SafeAreaView was applying the bottom inset when the KeyboardAvoidingView was up. To address this, I moved the SafeAreaView upstream to RegistrationNavigator, and moved KeyboardAvoidingView downstream to RegistrationContainer

Harbormaster completed remote builds in B18772: Diff 25719.Apr 25 2023, 2:27 PM
atul accepted this revision.Apr 26 2023, 1:14 PM
This revision is now accepted and ready to land.Apr 26 2023, 1:14 PM
Closed by commit rCOMMfd6dcca13669: [native] Add SafeAreaView to RegistrationContainer (authored by ashoat). · Explain WhyApr 26 2023, 1:23 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMfd6dcca13669: [native] Add SafeAreaView to RegistrationContainer.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
22 lines

Diff 25635

View Options

native/account/registration/registration-container.react.js

Loading...