[native] Add SafeAreaView to RegistrationContainer
ClosedPublic
Actions

Authored by ashoat on Apr 24 2023, 5:41 PM.

Details

Reviewers

ginsu
atul

Commits

rCOMMfd6dcca13669: [native] Add SafeAreaView to RegistrationContainer

Summary

See designs

Depends on D7598

Test Plan

	before	after
ios
android

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/registration

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Apr 24 2023, 5:41 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 24 2023, 5:41 PM

ashoat edited the test plan for this revision. (Show Details)Apr 24 2023, 5:45 PM

Harbormaster completed remote builds in B18722: Diff 25635.Apr 24 2023, 5:59 PM

ashoat requested review of this revision.Apr 24 2023, 5:59 PM

atul attached a referenced file: F506276: Screenshot 2023-04-24 at 8.35.43 PM.png. (Show Details)Apr 25 2023, 10:43 AM

ashoat mentioned this in D7593: [native] Make RegistrationContainer scrollable.Apr 25 2023, 2:03 PM

I was seeing an issue where the SafeAreaView was applying the bottom inset when the KeyboardAvoidingView was up. To address this, I moved the SafeAreaView upstream to RegistrationNavigator, and moved KeyboardAvoidingView downstream to RegistrationContainer