[native] Add SafeAreaView to RegistrationContainer
ClosedPublic
Actions

Authored by ashoat on Apr 25 2023, 12:41 AM.

Details

Reviewers

ginsu
atul

Commits

rCOMMfd6dcca13669: [native] Add SafeAreaView to RegistrationContainer

Summary

See designs

Depends on D7598

Test Plan

	before	after
ios
android

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Apr 25 2023, 12:41 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 25 2023, 12:41 AM

ashoat edited the test plan for this revision. (Show Details)Apr 25 2023, 12:45 AM

Harbormaster completed remote builds in B18722: Diff 25635.Apr 25 2023, 12:59 AM

ashoat requested review of this revision.Apr 25 2023, 12:59 AM

atul attached a referenced file: F506276: Screenshot 2023-04-24 at 8.35.43 PM.png. (Show Details)Apr 25 2023, 5:43 PM

ashoat mentioned this in D7593: [native] Make RegistrationContainer scrollable.Apr 25 2023, 9:03 PM

I was seeing an issue where the SafeAreaView was applying the bottom inset when the KeyboardAvoidingView was up. To address this, I moved the SafeAreaView upstream to RegistrationNavigator, and moved KeyboardAvoidingView downstream to RegistrationContainer