Page MenuHomePhabricator

[native] Join a thread after accepting the invitation
ClosedPublic

Authored by tomek on Apr 21 2023, 3:25 AM.
Tags
None
Referenced Files
F3389056: D7557.id25777.diff
Fri, Nov 29, 5:20 PM
F3388657: D7557.diff
Fri, Nov 29, 3:29 PM
Unknown Object (File)
Fri, Nov 8, 2:10 PM
Unknown Object (File)
Fri, Nov 8, 10:11 AM
Unknown Object (File)
Fri, Nov 8, 9:38 AM
Unknown Object (File)
Fri, Nov 8, 7:33 AM
Unknown Object (File)
Sun, Nov 3, 4:43 PM
Unknown Object (File)
Oct 28 2024, 1:26 AM
Subscribers

Details

Summary

After clicking join button, a user joins a community. The part of this code with calendar filters was inspired by other places where user can join a thread.
Error handling and loading state will be added in next diffs.

Depends on D7556

Test Plan

Open a link to a new community. Accept the invitation - a new thread should appear on thread list and in community drawer. Also, the modal should get closed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Apr 21 2023, 3:42 AM
tomek retitled this revision from [keyserver] Join a thread after accepting the invitation to [native] Join a thread after accepting the invitation.Apr 21 2023, 3:47 AM
native/navigation/invite-link-modal.react.js
95 ↗(On Diff #25507)

Is there any risk of the button being pressed multiple times, leading to multiple dispatches of callJoinThread and multiple goBack ReactNav actions being dispatched?

The latter could be addressed with goBackOnce, but ultimately it might be better to disable the Button once it is pressed.

95 ↗(On Diff #25507)

I guess perhaps this is handled in later diffs:

Error handling and loading state will be added in next diffs.

native/navigation/invite-link-modal.react.js
95 ↗(On Diff #25507)

Indeed, it's handled in D7558. Ignore my comments!

This revision is now accepted and ready to land.Apr 24 2023, 8:42 PM