Details

Reviewers

atul
ashoat

Commits

rCOMMb62c392ba505: [web] Caclulate encrypted media sha256

Summary

Web counterpart of D7647.
Sometimes encountered weird errors when creating the olm.Utility multiple times so decided to cache the instance and lazy-init Olm.

Due to ENG-3845 I decided to opt out of Olm here and used WebCrypto instead

Test Plan

Added console.log in encryptMedia() and sent encrypted photo. Verified that the hash is calculated

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Apr 29 2023, 9:16 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptApr 29 2023, 9:16 AM

bartek added a child revision: D7690: [web] Upload encrypted media to Blob service.Apr 29 2023, 9:23 AM

bartek published this revision for review.Apr 29 2023, 9:25 AM

Harbormaster completed remote builds in B18938: Diff 25937.Apr 29 2023, 9:33 AM

Please address inline comment before landing. If it doesn't make sense or you feel like I am missing something, feel free to re-request review

web/olm/olm-utils.js
17–24	There is a risk here of a race that leads to two instantiations. We can avoid that

This revision is now accepted and ready to land.Apr 29 2023, 12:01 PM

ashoat added inline comments.Apr 29 2023, 12:17 PM

web/olm/olm-utils.js

17–24

Actually I missed a line here:

let olmUtilityInstance;
function olmUtility(): Promise<Utility> {
  if (!olmUtilityInstance) {
    olmUtilityInstance = (async () => {
      await initOlm();
      olmUtilityInstance = new olm.Utility();
      return olmUtilityInstance;
    })();
  }
  return Promise.resolve(olmUtilityInstance);
}