Paths

Table of Contentst

Differential D7698

[native] Fix ComposedMessage width constraint to only include content
ClosedPublic
Actions

Authored by ashoat on May 1 2023, 1:06 PM.

Tags

None

Referenced Files

	F3361228: D7698.diff
	Sun, Nov 24, 3:52 PM

	F3356408: D7698.diff
	Sat, Nov 23, 6:47 PM

	Unknown Object (File)
	Mon, Nov 4, 12:21 PM

	Unknown Object (File)
	Sun, Oct 27, 1:29 AM

	Unknown Object (File)
	Sun, Oct 27, 1:29 AM

	Unknown Object (File)
	Sun, Oct 27, 1:29 AM

	Unknown Object (File)
	Sun, Oct 27, 1:26 AM

	Unknown Object (File)
	Fri, Oct 25, 9:09 PM

Subscribers

Details

Reviewers

ginsu
atul

Commits

rCOMMcde14a0ab2b7: [native] Fix ComposedMessage width constraint to only include content

Summary

The avatar should not be part of the width constraint. The width constraint is only meant to apply to the content. This change fixes ENG-3826, and makes the width match for non-viewer and viewer (no avatar) messages.

Our ability to use this fix is actually kind of a coincidence... this diff sidesteps the issue more than anything. It's lucky we don't need to include avatar here... if we did, we would probably be facing a serious React Native bug. Including this simplified non-working example for future reference: https://gist.github.com/Ashoat/f0f00496d17db8df18c2cf21f753f469

Depends on D7697

Test Plan

before	after

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 1 2023, 1:06 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 1 2023, 1:06 PM

ashoat edited the summary of this revision. (Show Details)May 1 2023, 1:08 PM

ashoat edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B18961: Diff 25973.May 1 2023, 1:27 PM

ashoat requested review of this revision.May 1 2023, 1:27 PM

atul accepted this revision.May 1 2023, 1:47 PM

This revision is now accepted and ready to land.May 1 2023, 1:47 PM

patched in the changes and played around with the views and everything looks good, no more bounds being overflown. Thanks for fixing this

Closed by commit rCOMMcde14a0ab2b7: [native] Fix ComposedMessage width constraint to only include content (authored by ashoat). · Explain WhyMay 1 2023, 1:55 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMcde14a0ab2b7: [native] Fix ComposedMessage width constraint to only include content.

Revision Contents
Changeset List

Path

Size

native/

chat/

composed-message.react.js

15 lines

Diff 25979

native/chat/composed-message.react.js

Loading...