Page MenuHomePhabricator
Differential D7694

[native] register user on native (rust changes)
ClosedPublic
Actions

Authored by varun on May 1 2023, 7:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 18, 12:27 AM
Unknown Object (File)
Tue, Apr 15, 11:14 PM
Unknown Object (File)
Sun, Apr 13, 10:01 PM
Unknown Object (File)
Fri, Apr 4, 2:53 PM
Unknown Object (File)
Thu, Apr 3, 9:43 PM
Unknown Object (File)
Sun, Mar 30, 9:12 PM
Unknown Object (File)
Sun, Mar 30, 9:12 PM
Unknown Object (File)
Sun, Mar 30, 9:12 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMMbf0a8c3d1ca3: [native] register user on native (rust changes)
Summary

add register_user function to native rust library

Test Plan

tested in subsequent diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.May 1 2023, 7:24 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 1 2023, 7:24 AM
Harbormaster completed remote builds in B18954: Diff 25964.May 1 2023, 7:42 AM
varun requested review of this revision.May 1 2023, 7:42 AM
varun added a child revision: D7695: [native] register user on native (C++ changes).May 1 2023, 7:46 AM
• jon requested changes to this revision.May 1 2023, 11:55 AM
• jon added inline comments.
native/native_rust_library/src/lib.rs
222 ↗(On Diff #25964)

please rebase, this should be content keys

This revision now requires changes to proceed.May 1 2023, 11:55 AM
varun updated this revision to Diff 26015.May 2 2023, 12:25 PM

rebase

varun updated this revision to Diff 26016.May 2 2023, 12:39 PM

rename identity -> content

Harbormaster completed remote builds in B18995: Diff 26015.May 2 2023, 12:45 PM
Harbormaster completed remote builds in B18996: Diff 26016.May 2 2023, 12:59 PM
• jon accepted this revision.May 2 2023, 5:40 PM
This revision is now accepted and ready to land.May 2 2023, 5:40 PM
Closed by commit rCOMMbf0a8c3d1ca3: [native] register user on native (rust changes) (authored by varun). · Explain WhyMay 3 2023, 2:02 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMbf0a8c3d1ca3: [native] register user on native (rust changes).

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
2 lines
src/
16 lines
141 lines

Diff 26016

View Options

native/native_rust_library/Cargo.lock

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines if (filter?.accessibleToUserID) {
primaryFetchClause = SQL` primaryFetchClause = SQL`
FROM threads t FROM threads t
`; `;
} }
const whereClause = filter ? constructWhereClause(filter) : ''; const whereClause = filter ? constructWhereClause(filter) : '';
const rolesQuery = SQL` const rolesQuery = SQL`
SELECT t.id, r.id AS role, r.name, r.permissions, SELECT t.id, r.id AS role, r.name, r.permissions, r.special_role,
r.special_role = ${specialRoles.DEFAULT_ROLE} AS is_default r.special_role = ${specialRoles.DEFAULT_ROLE} AS is_default
` `
.append(primaryFetchClause) .append(primaryFetchClause)
.append( .append(
SQL` SQL`
LEFT JOIN roles r ON r.thread = t.id LEFT JOIN roles r ON r.thread = t.id
`, `,
) )
▲ Show 20 Lines • Show All 121 Lines • ▼ Show 20 Lines for (const rolesRow of rolesResult) {
} }
const role = rolesRow.role.toString(); const role = rolesRow.role.toString();
if (!threadInfos[threadID].roles[role]) { if (!threadInfos[threadID].roles[role]) {
threadInfos[threadID].roles[role] = { threadInfos[threadID].roles[role] = {
id: role, id: role,
name: rolesRow.name, name: rolesRow.name,
permissions: JSON.parse(rolesRow.permissions), permissions: JSON.parse(rolesRow.permissions),
isDefault: Boolean(rolesRow.is_default), isDefault: Boolean(rolesRow.is_default),
specialRole: rolesRow.special_role,
}; };
} }
} }
return { threadInfos }; return { threadInfos };
} }
export type FetchThreadInfosResult = { export type FetchThreadInfosResult = {
▲ Show 20 Lines • Show All 168 Lines • Show Last 20 Lines
View Options

native/native_rust_library/Cargo.toml

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines if (filter?.accessibleToUserID) {
primaryFetchClause = SQL` primaryFetchClause = SQL`
FROM threads t FROM threads t
`; `;
} }
const whereClause = filter ? constructWhereClause(filter) : ''; const whereClause = filter ? constructWhereClause(filter) : '';
const rolesQuery = SQL` const rolesQuery = SQL`
SELECT t.id, r.id AS role, r.name, r.permissions, SELECT t.id, r.id AS role, r.name, r.permissions, r.special_role,
r.special_role = ${specialRoles.DEFAULT_ROLE} AS is_default r.special_role = ${specialRoles.DEFAULT_ROLE} AS is_default
` `
.append(primaryFetchClause) .append(primaryFetchClause)
.append( .append(
SQL` SQL`
LEFT JOIN roles r ON r.thread = t.id LEFT JOIN roles r ON r.thread = t.id
`, `,
) )
▲ Show 20 Lines • Show All 121 Lines • ▼ Show 20 Lines for (const rolesRow of rolesResult) {
} }
const role = rolesRow.role.toString(); const role = rolesRow.role.toString();
if (!threadInfos[threadID].roles[role]) { if (!threadInfos[threadID].roles[role]) {
threadInfos[threadID].roles[role] = { threadInfos[threadID].roles[role] = {
id: role, id: role,
name: rolesRow.name, name: rolesRow.name,
permissions: JSON.parse(rolesRow.permissions), permissions: JSON.parse(rolesRow.permissions),
isDefault: Boolean(rolesRow.is_default), isDefault: Boolean(rolesRow.is_default),
specialRole: rolesRow.special_role,
}; };
} }
} }
return { threadInfos }; return { threadInfos };
} }
export type FetchThreadInfosResult = { export type FetchThreadInfosResult = {
▲ Show 20 Lines • Show All 168 Lines • Show Last 20 Lines
View Options

native/native_rust_library/src/identity_client.rs

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines if (filter?.accessibleToUserID) {
primaryFetchClause = SQL` primaryFetchClause = SQL`
FROM threads t FROM threads t
`; `;
} }
const whereClause = filter ? constructWhereClause(filter) : ''; const whereClause = filter ? constructWhereClause(filter) : '';
const rolesQuery = SQL` const rolesQuery = SQL`
SELECT t.id, r.id AS role, r.name, r.permissions, SELECT t.id, r.id AS role, r.name, r.permissions, r.special_role,
r.special_role = ${specialRoles.DEFAULT_ROLE} AS is_default r.special_role = ${specialRoles.DEFAULT_ROLE} AS is_default
` `
.append(primaryFetchClause) .append(primaryFetchClause)
.append( .append(
SQL` SQL`
LEFT JOIN roles r ON r.thread = t.id LEFT JOIN roles r ON r.thread = t.id
`, `,
) )
▲ Show 20 Lines • Show All 121 Lines • ▼ Show 20 Lines for (const rolesRow of rolesResult) {
} }
const role = rolesRow.role.toString(); const role = rolesRow.role.toString();
if (!threadInfos[threadID].roles[role]) { if (!threadInfos[threadID].roles[role]) {
threadInfos[threadID].roles[role] = { threadInfos[threadID].roles[role] = {
id: role, id: role,
name: rolesRow.name, name: rolesRow.name,
permissions: JSON.parse(rolesRow.permissions), permissions: JSON.parse(rolesRow.permissions),
isDefault: Boolean(rolesRow.is_default), isDefault: Boolean(rolesRow.is_default),
specialRole: rolesRow.special_role,
}; };
} }
} }
return { threadInfos }; return { threadInfos };
} }
export type FetchThreadInfosResult = { export type FetchThreadInfosResult = {
▲ Show 20 Lines • Show All 168 Lines • Show Last 20 Lines
View Options

native/native_rust_library/src/lib.rs

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines if (filter?.accessibleToUserID) {
primaryFetchClause = SQL` primaryFetchClause = SQL`
FROM threads t FROM threads t
`; `;
} }
const whereClause = filter ? constructWhereClause(filter) : ''; const whereClause = filter ? constructWhereClause(filter) : '';
const rolesQuery = SQL` const rolesQuery = SQL`
SELECT t.id, r.id AS role, r.name, r.permissions, SELECT t.id, r.id AS role, r.name, r.permissions, r.special_role,
r.special_role = ${specialRoles.DEFAULT_ROLE} AS is_default r.special_role = ${specialRoles.DEFAULT_ROLE} AS is_default
` `
.append(primaryFetchClause) .append(primaryFetchClause)
.append( .append(
SQL` SQL`
LEFT JOIN roles r ON r.thread = t.id LEFT JOIN roles r ON r.thread = t.id
`, `,
) )
▲ Show 20 Lines • Show All 121 Lines • ▼ Show 20 Lines for (const rolesRow of rolesResult) {
} }
const role = rolesRow.role.toString(); const role = rolesRow.role.toString();
if (!threadInfos[threadID].roles[role]) { if (!threadInfos[threadID].roles[role]) {
threadInfos[threadID].roles[role] = { threadInfos[threadID].roles[role] = {
id: role, id: role,
name: rolesRow.name, name: rolesRow.name,
permissions: JSON.parse(rolesRow.permissions), permissions: JSON.parse(rolesRow.permissions),
isDefault: Boolean(rolesRow.is_default), isDefault: Boolean(rolesRow.is_default),
specialRole: rolesRow.special_role,
}; };
} }
} }
return { threadInfos }; return { threadInfos };
} }
export type FetchThreadInfosResult = { export type FetchThreadInfosResult = {
▲ Show 20 Lines • Show All 168 Lines • Show Last 20 Lines