Page MenuHomePhabricator
Differential D7694

[native] register user on native (rust changes)
ClosedPublic
Actions

Authored by varun on May 1 2023, 7:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 9:12 PM
Unknown Object (File)
Sun, Mar 30, 9:12 PM
Unknown Object (File)
Sun, Mar 30, 9:12 PM
Unknown Object (File)
Sun, Mar 30, 9:12 PM
Unknown Object (File)
Sat, Mar 29, 9:38 PM
Unknown Object (File)
Sat, Mar 29, 10:48 AM
Unknown Object (File)
Thu, Mar 27, 9:38 AM
Unknown Object (File)
Tue, Mar 25, 10:43 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMMbf0a8c3d1ca3: [native] register user on native (rust changes)
Summary

add register_user function to native rust library

Test Plan

tested in subsequent diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.May 1 2023, 7:24 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 1 2023, 7:24 AM
Harbormaster completed remote builds in B18954: Diff 25964.May 1 2023, 7:42 AM
varun requested review of this revision.May 1 2023, 7:42 AM
varun added a child revision: D7695: [native] register user on native (C++ changes).May 1 2023, 7:46 AM
• jon requested changes to this revision.May 1 2023, 11:55 AM
• jon added inline comments.
native/native_rust_library/src/lib.rs
222 ↗(On Diff #25964)

please rebase, this should be content keys

This revision now requires changes to proceed.May 1 2023, 11:55 AM
varun updated this revision to Diff 26015.May 2 2023, 12:25 PM

rebase

varun updated this revision to Diff 26016.May 2 2023, 12:39 PM

rename identity -> content

Harbormaster completed remote builds in B18995: Diff 26015.May 2 2023, 12:45 PM
Harbormaster completed remote builds in B18996: Diff 26016.May 2 2023, 12:59 PM
• jon accepted this revision.May 2 2023, 5:40 PM
This revision is now accepted and ready to land.May 2 2023, 5:40 PM
Closed by commit rCOMMbf0a8c3d1ca3: [native] register user on native (rust changes) (authored by varun). · Explain WhyMay 3 2023, 2:02 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMbf0a8c3d1ca3: [native] register user on native (rust changes).

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
2 lines
src/
16 lines
141 lines

Diff 26016

View Options

native/native_rust_library/Cargo.lock

// @flow // @flow
import { addCommunityActionType } from '../actions/community-actions.js'; import { addCommunityActionType } from '../actions/community-actions.js';
import { siweAuthActionTypes } from '../actions/siwe-actions.js';
import {
logInActionTypes,
keyserverRegisterActionTypes,
} from '../actions/user-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
type RemoveAllCommunitiesOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { CommunityStore } from '../types/community-types.js'; import type {
CommunityStore,
CommunityInfo,
} from '../types/community-types.js';
import { defaultEnabledApps } from '../types/enabled-apps.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
import type { RawThreadInfos } from '../types/thread-types';
import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js';
const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers; const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;
export default function reduceCommunityStore( export default function reduceCommunityStore(
state: CommunityStore, state: CommunityStore,
action: BaseAction, action: BaseAction,
newThreadInfos: RawThreadInfos,
): { ): {
communityStore: CommunityStore, communityStore: CommunityStore,
communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>, communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
} { } {
if (action.type === addCommunityActionType) { if (
action.type === logInActionTypes.success ||
action.type === siweAuthActionTypes.success ||
action.type === keyserverRegisterActionTypes.success
) {
kamilUnsubmitted
Not Done
Inline Actions

wondering, shouldn't we also add action.type === fullStateSyncActionType?

kamil: wondering, shouldn't we also add `action.type === fullStateSyncActionType`?
ginsuAuthorUnsubmitted
Done
Inline Actions

I spoke to @atul about this and from what I understood we don't need this type since the community store is not synced with the keyserver

ginsu: I spoke to @atul about this and from what I understood we don't need this type since the…
kamilUnsubmitted
Not Done
Inline Actions

But based on the code below, communities are computed based on newThreadInfos which are synced - see here (cc. @atul)

I am afraid that on fullStateSyncActionType we will have inconsistency between threads (threadTypeIsCommunityRoot) and communities in this store

kamil: But based on the code below, communities are computed based on `newThreadInfos` which are…
const removeAllOpertation: RemoveAllCommunitiesOperation = {
type: 'remove_all_communities',
};
const replaceOperations = Object.keys(newThreadInfos)
.filter(threadID =>
threadTypeIsCommunityRoot(newThreadInfos[threadID].type),
)
.map(threadID => {
const communityInfo: CommunityInfo = {
enabledApps: defaultEnabledApps,
};
return {
type: 'replace_community',
payload: {
id: threadID,
communityInfo,
},
};
});
atulUnsubmitted
Not Done
Inline Actions

You could do something like following:

const replaceOperations = Object.keys(newThreadInfos).reduce((acc, threadID) => {
  if (threadTypeIsCommunityRoot(newThreadInfos[threadID].type)) {
    const communityInfo = {
      enabledApps: defaultEnabledApps,
    };
    acc.push({
      type: 'replace_community',
      payload: {
        id: threadID,
        communityInfo,
      },
    });
  }
  return acc;
}, []);

(generated with ChatGPT)

that lets us avoid an iteration, but probably doesn't make a difference

atul: You could do something like following: ```lang=js const replaceOperations = Object.keys…
const commmunityStoreOperations = [
removeAllOpertation,
...replaceOperations,
];
return {
communityStore: processStoreOps(state, commmunityStoreOperations),
communityStoreOperations: commmunityStoreOperations,
};
} else if (action.type === addCommunityActionType) {
const replaceOperation: ReplaceCommunityOperation = { const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community', type: 'replace_community',
payload: { payload: {
id: action.payload.id, id: action.payload.id,
communityInfo: { communityInfo: {
...action.payload.newCommunityInfo, ...action.payload.newCommunityInfo,
}, },
}, },
Show All 13 Lines
View Options

native/native_rust_library/Cargo.toml

// @flow // @flow
import { addCommunityActionType } from '../actions/community-actions.js'; import { addCommunityActionType } from '../actions/community-actions.js';
import { siweAuthActionTypes } from '../actions/siwe-actions.js';
import {
logInActionTypes,
keyserverRegisterActionTypes,
} from '../actions/user-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
type RemoveAllCommunitiesOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { CommunityStore } from '../types/community-types.js'; import type {
CommunityStore,
CommunityInfo,
} from '../types/community-types.js';
import { defaultEnabledApps } from '../types/enabled-apps.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
import type { RawThreadInfos } from '../types/thread-types';
import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js';
const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers; const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;
export default function reduceCommunityStore( export default function reduceCommunityStore(
state: CommunityStore, state: CommunityStore,
action: BaseAction, action: BaseAction,
newThreadInfos: RawThreadInfos,
): { ): {
communityStore: CommunityStore, communityStore: CommunityStore,
communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>, communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
} { } {
if (action.type === addCommunityActionType) { if (
action.type === logInActionTypes.success ||
action.type === siweAuthActionTypes.success ||
action.type === keyserverRegisterActionTypes.success
) {
kamilUnsubmitted
Not Done
Inline Actions

wondering, shouldn't we also add action.type === fullStateSyncActionType?

kamil: wondering, shouldn't we also add `action.type === fullStateSyncActionType`?
ginsuAuthorUnsubmitted
Done
Inline Actions

I spoke to @atul about this and from what I understood we don't need this type since the community store is not synced with the keyserver

ginsu: I spoke to @atul about this and from what I understood we don't need this type since the…
kamilUnsubmitted
Not Done
Inline Actions

But based on the code below, communities are computed based on newThreadInfos which are synced - see here (cc. @atul)

I am afraid that on fullStateSyncActionType we will have inconsistency between threads (threadTypeIsCommunityRoot) and communities in this store

kamil: But based on the code below, communities are computed based on `newThreadInfos` which are…
const removeAllOpertation: RemoveAllCommunitiesOperation = {
type: 'remove_all_communities',
};
const replaceOperations = Object.keys(newThreadInfos)
.filter(threadID =>
threadTypeIsCommunityRoot(newThreadInfos[threadID].type),
)
.map(threadID => {
const communityInfo: CommunityInfo = {
enabledApps: defaultEnabledApps,
};
return {
type: 'replace_community',
payload: {
id: threadID,
communityInfo,
},
};
});
atulUnsubmitted
Not Done
Inline Actions

You could do something like following:

const replaceOperations = Object.keys(newThreadInfos).reduce((acc, threadID) => {
  if (threadTypeIsCommunityRoot(newThreadInfos[threadID].type)) {
    const communityInfo = {
      enabledApps: defaultEnabledApps,
    };
    acc.push({
      type: 'replace_community',
      payload: {
        id: threadID,
        communityInfo,
      },
    });
  }
  return acc;
}, []);

(generated with ChatGPT)

that lets us avoid an iteration, but probably doesn't make a difference

atul: You could do something like following: ```lang=js const replaceOperations = Object.keys…
const commmunityStoreOperations = [
removeAllOpertation,
...replaceOperations,
];
return {
communityStore: processStoreOps(state, commmunityStoreOperations),
communityStoreOperations: commmunityStoreOperations,
};
} else if (action.type === addCommunityActionType) {
const replaceOperation: ReplaceCommunityOperation = { const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community', type: 'replace_community',
payload: { payload: {
id: action.payload.id, id: action.payload.id,
communityInfo: { communityInfo: {
...action.payload.newCommunityInfo, ...action.payload.newCommunityInfo,
}, },
}, },
Show All 13 Lines
View Options

native/native_rust_library/src/identity_client.rs

// @flow // @flow
import { addCommunityActionType } from '../actions/community-actions.js'; import { addCommunityActionType } from '../actions/community-actions.js';
import { siweAuthActionTypes } from '../actions/siwe-actions.js';
import {
logInActionTypes,
keyserverRegisterActionTypes,
} from '../actions/user-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
type RemoveAllCommunitiesOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { CommunityStore } from '../types/community-types.js'; import type {
CommunityStore,
CommunityInfo,
} from '../types/community-types.js';
import { defaultEnabledApps } from '../types/enabled-apps.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
import type { RawThreadInfos } from '../types/thread-types';
import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js';
const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers; const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;
export default function reduceCommunityStore( export default function reduceCommunityStore(
state: CommunityStore, state: CommunityStore,
action: BaseAction, action: BaseAction,
newThreadInfos: RawThreadInfos,
): { ): {
communityStore: CommunityStore, communityStore: CommunityStore,
communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>, communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
} { } {
if (action.type === addCommunityActionType) { if (
action.type === logInActionTypes.success ||
action.type === siweAuthActionTypes.success ||
action.type === keyserverRegisterActionTypes.success
) {
kamilUnsubmitted
Not Done
Inline Actions

wondering, shouldn't we also add action.type === fullStateSyncActionType?

kamil: wondering, shouldn't we also add `action.type === fullStateSyncActionType`?
ginsuAuthorUnsubmitted
Done
Inline Actions

I spoke to @atul about this and from what I understood we don't need this type since the community store is not synced with the keyserver

ginsu: I spoke to @atul about this and from what I understood we don't need this type since the…
kamilUnsubmitted
Not Done
Inline Actions

But based on the code below, communities are computed based on newThreadInfos which are synced - see here (cc. @atul)

I am afraid that on fullStateSyncActionType we will have inconsistency between threads (threadTypeIsCommunityRoot) and communities in this store

kamil: But based on the code below, communities are computed based on `newThreadInfos` which are…
const removeAllOpertation: RemoveAllCommunitiesOperation = {
type: 'remove_all_communities',
};
const replaceOperations = Object.keys(newThreadInfos)
.filter(threadID =>
threadTypeIsCommunityRoot(newThreadInfos[threadID].type),
)
.map(threadID => {
const communityInfo: CommunityInfo = {
enabledApps: defaultEnabledApps,
};
return {
type: 'replace_community',
payload: {
id: threadID,
communityInfo,
},
};
});
atulUnsubmitted
Not Done
Inline Actions

You could do something like following:

const replaceOperations = Object.keys(newThreadInfos).reduce((acc, threadID) => {
  if (threadTypeIsCommunityRoot(newThreadInfos[threadID].type)) {
    const communityInfo = {
      enabledApps: defaultEnabledApps,
    };
    acc.push({
      type: 'replace_community',
      payload: {
        id: threadID,
        communityInfo,
      },
    });
  }
  return acc;
}, []);

(generated with ChatGPT)

that lets us avoid an iteration, but probably doesn't make a difference

atul: You could do something like following: ```lang=js const replaceOperations = Object.keys…
const commmunityStoreOperations = [
removeAllOpertation,
...replaceOperations,
];
return {
communityStore: processStoreOps(state, commmunityStoreOperations),
communityStoreOperations: commmunityStoreOperations,
};
} else if (action.type === addCommunityActionType) {
const replaceOperation: ReplaceCommunityOperation = { const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community', type: 'replace_community',
payload: { payload: {
id: action.payload.id, id: action.payload.id,
communityInfo: { communityInfo: {
...action.payload.newCommunityInfo, ...action.payload.newCommunityInfo,
}, },
}, },
Show All 13 Lines
View Options

native/native_rust_library/src/lib.rs

// @flow // @flow
import { addCommunityActionType } from '../actions/community-actions.js'; import { addCommunityActionType } from '../actions/community-actions.js';
import { siweAuthActionTypes } from '../actions/siwe-actions.js';
import {
logInActionTypes,
keyserverRegisterActionTypes,
} from '../actions/user-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
type RemoveAllCommunitiesOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { CommunityStore } from '../types/community-types.js'; import type {
CommunityStore,
CommunityInfo,
} from '../types/community-types.js';
import { defaultEnabledApps } from '../types/enabled-apps.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
import type { RawThreadInfos } from '../types/thread-types';
import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js';
const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers; const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;
export default function reduceCommunityStore( export default function reduceCommunityStore(
state: CommunityStore, state: CommunityStore,
action: BaseAction, action: BaseAction,
newThreadInfos: RawThreadInfos,
): { ): {
communityStore: CommunityStore, communityStore: CommunityStore,
communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>, communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
} { } {
if (action.type === addCommunityActionType) { if (
action.type === logInActionTypes.success ||
action.type === siweAuthActionTypes.success ||
action.type === keyserverRegisterActionTypes.success
) {
kamilUnsubmitted
Not Done
Inline Actions

wondering, shouldn't we also add action.type === fullStateSyncActionType?

kamil: wondering, shouldn't we also add `action.type === fullStateSyncActionType`?
ginsuAuthorUnsubmitted
Done
Inline Actions

I spoke to @atul about this and from what I understood we don't need this type since the community store is not synced with the keyserver

ginsu: I spoke to @atul about this and from what I understood we don't need this type since the…
kamilUnsubmitted
Not Done
Inline Actions

But based on the code below, communities are computed based on newThreadInfos which are synced - see here (cc. @atul)

I am afraid that on fullStateSyncActionType we will have inconsistency between threads (threadTypeIsCommunityRoot) and communities in this store

kamil: But based on the code below, communities are computed based on `newThreadInfos` which are…
const removeAllOpertation: RemoveAllCommunitiesOperation = {
type: 'remove_all_communities',
};
const replaceOperations = Object.keys(newThreadInfos)
.filter(threadID =>
threadTypeIsCommunityRoot(newThreadInfos[threadID].type),
)
.map(threadID => {
const communityInfo: CommunityInfo = {
enabledApps: defaultEnabledApps,
};
return {
type: 'replace_community',
payload: {
id: threadID,
communityInfo,
},
};
});
atulUnsubmitted
Not Done
Inline Actions

You could do something like following:

const replaceOperations = Object.keys(newThreadInfos).reduce((acc, threadID) => {
  if (threadTypeIsCommunityRoot(newThreadInfos[threadID].type)) {
    const communityInfo = {
      enabledApps: defaultEnabledApps,
    };
    acc.push({
      type: 'replace_community',
      payload: {
        id: threadID,
        communityInfo,
      },
    });
  }
  return acc;
}, []);

(generated with ChatGPT)

that lets us avoid an iteration, but probably doesn't make a difference

atul: You could do something like following: ```lang=js const replaceOperations = Object.keys…
const commmunityStoreOperations = [
removeAllOpertation,
...replaceOperations,
];
return {
communityStore: processStoreOps(state, commmunityStoreOperations),
communityStoreOperations: commmunityStoreOperations,
};
} else if (action.type === addCommunityActionType) {
const replaceOperation: ReplaceCommunityOperation = { const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community', type: 'replace_community',
payload: { payload: {
id: action.payload.id, id: action.payload.id,
communityInfo: { communityInfo: {
...action.payload.newCommunityInfo, ...action.payload.newCommunityInfo,
}, },
}, },
Show All 13 Lines