Page MenuHomePhabricator
Differential D7672

[native] Create a new screen to display the thread's pinned messages
ClosedPublic
Actions

Authored by rohan on Apr 27 2023, 11:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 8:52 PM
Unknown Object (File)
Mon, Nov 25, 8:52 PM
Unknown Object (File)
Mon, Nov 25, 8:52 PM
Unknown Object (File)
Sun, Nov 24, 10:39 AM
Unknown Object (File)
Sun, Nov 24, 10:03 AM
Unknown Object (File)
Sun, Nov 24, 9:45 AM
Unknown Object (File)
Thu, Nov 14, 8:03 AM
Unknown Object (File)
Thu, Nov 14, 7:58 AM
View All Files
Subscribers
ashoat
inka

Details

Reviewers
ginsu
tomek
ashoat
inka
atul
Commits
rCOMM2e1c72c3d557: [native] Create a new screen to display the thread's pinned messages
Summary

Create a very basic new screen to show the thraed's pinned messages (this screen
will be re-used by the message search work on native).

Implementation of the screen will come in the next diff, to make this one easier to
review.

Depends on D7614

Test Plan

Navigate to the screen by clicking on the pinned count banner from the previous
diff and make sure the screen is navigated to.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan created this revision.Apr 27 2023, 11:10 AM
Herald added a subscriber: ashoat. · View Herald TranscriptApr 27 2023, 11:10 AM
rohan added a child revision: D7673: [native] Display the pinned messages for the thread in the new screen.Apr 27 2023, 11:15 AM
Harbormaster completed remote builds in B18890: Diff 25874.Apr 27 2023, 11:27 AM
rohan requested review of this revision.Apr 27 2023, 11:27 AM
rohan updated this revision to Diff 26028.May 2 2023, 5:21 PM

Simplify headerTitle since the screen will be exclusive to pinned
messages

Harbormaster completed remote builds in B19008: Diff 26028.May 2 2023, 5:39 PM
atul resigned from this revision.May 3 2023, 8:12 AM
atul added a reviewer: ashoat.
ashoat accepted this revision.May 3 2023, 8:15 AM
ashoat added a reviewer: inka.
ashoat added a subscriber: inka.

Looks good, but should @inka be on this diff given that MessagesResult will be used for message search as well?

This revision is now accepted and ready to land.May 3 2023, 8:15 AM
rohan updated this revision to Diff 26136.May 5 2023, 4:26 PM

Rebase

Harbormaster completed remote builds in B19088: Diff 26136.May 5 2023, 4:43 PM
rohan updated this revision to Diff 26226.May 8 2023, 12:07 PM

Rebase

Harbormaster completed remote builds in B19155: Diff 26226.May 8 2023, 12:30 PM
Closed by commit rCOMM2e1c72c3d557: [native] Create a new screen to display the thread's pinned messages (authored by RohanK6 <rohan.khanderia@gmail.com>, committed by rohan). · Explain WhyMay 8 2023, 12:38 PM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM2e1c72c3d557: [native] Create a new screen to display the thread's pinned messages.

Revision Contents
Changeset List

PathSize
native/
chat/
11 lines
23 lines
24 lines
navigation/
4 lines

Diff 26028

View Options

native/chat/chat.react.js

Loading...
View Options

native/chat/message-list-container.react.js

Loading...
View Options

native/chat/message-results-screen.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...