Page MenuHomePhabricator
Differential D7680

[native] Used predefined function for discard edit mode alert
ClosedPublic
Actions

Authored by • kuba on Apr 28 2023, 2:22 AM.
Tags
None
Referenced Files
F1779773: D7680.diff
Sat, May 18, 12:33 AM
Unknown Object (File)
Wed, May 15, 7:57 PM
Unknown Object (File)
Tue, May 14, 2:20 AM
Unknown Object (File)
Sun, May 12, 2:28 PM
Unknown Object (File)
Fri, May 10, 1:34 AM
Unknown Object (File)
Wed, May 8, 12:23 AM
Unknown Object (File)
Sat, May 4, 1:12 PM
Unknown Object (File)
Mon, Apr 22, 12:01 PM
View All 33 Files
Subscribers
atul
tomek

Details

Reviewers
michal
inka
ashoat
Commits
rCOMM3c31b6487e39: [native] Used predefined function for discard edit mode alert
Summary

Used function, instead of creating a new alert.

Test Plan

Checked if the alert still works.

Diff Detail

Repository
rCOMM Comm
Branch
kuba/messageediting
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• kuba created this revision.Apr 28 2023, 2:22 AM
Herald added subscribers: atul, tomek. · View Herald TranscriptApr 28 2023, 2:22 AM
• kuba added a parent revision: D7630: [native] Blocking navigation in edit mode in ChatRouter.Apr 28 2023, 2:23 AM
Harbormaster completed remote builds in B18909: Diff 25901.Apr 28 2023, 2:40 AM
• kuba requested review of this revision.Apr 28 2023, 2:40 AM
ashoat requested changes to this revision.Apr 28 2023, 5:45 AM
ashoat added inline comments.
native/chat/chat-input-bar.react.js
970 ↗(On Diff #25901)

I think "Are you sure?" is too generic of a title here. It doesn't clarify what the user is doing exactly

I think I prefer the copy on line 970 and 971, but with some changes:

Alert.alert(
  'Discard changes?',
  'You have unsaved changes which will be discarded if you navigate away.',
);

We can keep this change here, but can you update exitEditAlert to match this proposed new copy?

This revision now requires changes to proceed.Apr 28 2023, 5:45 AM
• kuba updated this revision to Diff 26347.May 10 2023, 6:51 AM

Changed discard alert content

Harbormaster completed remote builds in B19245: Diff 26347.May 10 2023, 7:08 AM
• kuba added a child revision: D7789: [native] Introduced new types for Reanimated.May 11 2023, 2:54 AM
• kuba removed a parent revision: D7630: [native] Blocking navigation in edit mode in ChatRouter.May 11 2023, 3:19 AM
ashoat accepted this revision.May 11 2023, 8:42 AM
This revision is now accepted and ready to land.May 11 2023, 8:42 AM
Closed by commit rCOMM3c31b6487e39: [native] Used predefined function for discard edit mode alert (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyMay 16 2023, 3:49 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMM3c31b6487e39: [native] Used predefined function for discard edit mode alert.

Revision Contents
Changeset List

PathSize
native/
chat/
14 lines
utils/
28 lines

Diff 26347

View Options

native/chat/chat-input-bar.react.js

Loading...
View Options

native/utils/edit-messages-utils.js

Loading...