Page MenuHomePhabricator
Differential D7790

[native] Added animation to the edit box when entering/leaving edit mode
ClosedPublic
Actions

Authored by • kuba on May 11 2023, 2:30 AM.
Tags
None
Referenced Files
F2109385: D7790.diff
Tue, Jun 25, 4:10 PM
Unknown Object (File)
Fri, Jun 7, 8:22 AM
Unknown Object (File)
Tue, Jun 4, 1:17 PM
Unknown Object (File)
Thu, May 30, 8:08 PM
Unknown Object (File)
Wed, May 29, 1:13 AM
Unknown Object (File)
Wed, May 29, 1:13 AM
Unknown Object (File)
Wed, May 29, 1:12 AM
Unknown Object (File)
Tue, May 28, 10:27 AM
View All 40 Files
Subscribers
atul
tomek

Details

Reviewers
ashoat
inka
michal
Commits
rCOMMee38c51336f4: [native] Added animation to the edit box when entering/leaving edit mode
Summary

Added appearning and disappearing animation to the edit message box in edit mode.

Test Plan

Run the app. Check the animations.

Videos: (might look a little bit laggy on simulator, didn't have access to physical devices)

iOS:

Android:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• kuba created this revision.May 11 2023, 2:30 AM
Herald added subscribers: atul, tomek. · View Herald TranscriptMay 11 2023, 2:30 AM
• kuba added a parent revision: D7789: [native] Introduced new types for Reanimated.May 11 2023, 2:31 AM
• kuba added a child revision: D7791: [native] Added animation to the highlight of edited message.
• kuba edited the test plan for this revision. (Show Details)
• kuba edited the test plan for this revision. (Show Details)May 11 2023, 2:34 AM
• kuba edited the test plan for this revision. (Show Details)
• kuba mentioned this in D7791: [native] Added animation to the highlight of edited message.
Harbormaster completed remote builds in B19264: Diff 26366.May 11 2023, 2:47 AM
• kuba requested review of this revision.May 11 2023, 2:47 AM
ashoat accepted this revision.May 12 2023, 2:15 AM
This revision is now accepted and ready to land.May 12 2023, 2:15 AM
Closed by commit rCOMMee38c51336f4: [native] Added animation to the edit box when entering/leaving edit mode (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyMay 22 2023, 7:05 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> mentioned this in rCOMM204fc8185ca8: [native] Added animation to the highlight of edited message.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMMee38c51336f4: [native] Added animation to the edit box when entering/leaving edit mode.

Revision Contents
Changeset List

PathSize
native/
chat/
16 lines

Diff 26366

View Options

native/chat/chat-input-bar.react.js

Loading...