Added appearning and disappearing animation to the highlight of the edited message.
Details
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
native/chat/composed-message.react.js | ||
---|---|---|
219 ↗ | (On Diff #26367) | Have you noticed we don't use Animated.View directly? I think you should be using AnimatedView |
native/chat/composed-message.react.js | ||
---|---|---|
219 ↗ | (On Diff #26367) | I believe that we use Animated.View in several places, where we animate element styles, like here. I.g. in logged-out-modal.react.js, image-modal.react.js. Simply changing it generates type error:
Should I have a look at it? |
native/chat/composed-message.react.js | ||
---|---|---|
63 ↗ | (On Diff #26367) | All React prop types should be read-only |
219 ↗ | (On Diff #26367) | It's not immediately clear to me why you're seeing that error. Simply seeing the error isn't enough of an investigation – I'm curious to hear what you've tried, and what your investigation yielded. Please try investigating and share more details In particular, I'm curious what [1] is... I don't see you setting transform to null or undefined for any of these types, but I may be missing something
I'm not sure why this is... but AnimatedView must exist for a reason. If we think it does not need to exist, we could consider deprecating it. But while it exists, we should probably be using it |
native/chat/composed-message.react.js | ||
---|---|---|
97 ↗ | (On Diff #26498) | Can we remove this newline? |