Page MenuHomePhabricator

[native] Used predefined function for discard edit mode alert
ClosedPublic

Authored by kuba on Apr 28 2023, 2:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 3, 11:32 AM
Unknown Object (File)
Mon, Dec 2, 5:30 PM
Unknown Object (File)
Mon, Dec 2, 2:16 PM
Unknown Object (File)
Sat, Nov 30, 8:14 PM
Unknown Object (File)
Thu, Nov 21, 8:18 PM
Unknown Object (File)
Oct 30 2024, 6:20 PM
Unknown Object (File)
Oct 15 2024, 6:26 PM
Unknown Object (File)
Oct 1 2024, 11:00 PM
Subscribers

Details

Summary

Used function, instead of creating a new alert.

Test Plan

Checked if the alert still works.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat requested changes to this revision.Apr 28 2023, 5:45 AM
ashoat added inline comments.
native/chat/chat-input-bar.react.js
970 ↗(On Diff #25901)

I think "Are you sure?" is too generic of a title here. It doesn't clarify what the user is doing exactly

I think I prefer the copy on line 970 and 971, but with some changes:

Alert.alert(
  'Discard changes?',
  'You have unsaved changes which will be discarded if you navigate away.',
);

We can keep this change here, but can you update exitEditAlert to match this proposed new copy?

This revision now requires changes to proceed.Apr 28 2023, 5:45 AM

Changed discard alert content

This revision is now accepted and ready to land.May 11 2023, 8:42 AM