Paths

Table of Contentst

Differential D7826

[native] Disable overscroll for RegistrationContainer on iOS
ClosedPublic
Actions

Authored by ashoat on May 16 2023, 3:41 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 30, 5:00 PM

	Unknown Object (File)
	Nov 16 2024, 12:13 PM

	Unknown Object (File)
	Nov 1 2024, 6:07 PM

	Unknown Object (File)
	Nov 1 2024, 6:07 PM

	Unknown Object (File)
	Nov 1 2024, 6:07 PM

	Unknown Object (File)
	Nov 1 2024, 6:01 PM

	Unknown Object (File)
	Oct 10 2024, 4:09 AM

	Unknown Object (File)
	Oct 5 2024, 2:39 AM

View All 54 Files

Subscribers

Details

Reviewers

ginsu
atul

Commits

rCOMM08bf2853b10b: [native] Disable overscroll for RegistrationContainer on iOS

Summary

Android already disables overscroll when the content is smaller than the ScrollView. This diff makes iOS do the same.

Test Plan

Confirmed that iOS behaves as if there is no ScrollView when the content is smaller than the ScrollView
Confirmed that no change was observed when the content is larger than the ScrollView (it remains scrollable) by adding more bullet points to the ConnectEthereum screen

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 16 2023, 3:41 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 16 2023, 3:41 AM

Harbormaster completed remote builds in B19368: Diff 26500.May 16 2023, 3:59 AM

ashoat requested review of this revision.May 16 2023, 3:59 AM

ginsu accepted this revision.May 16 2023, 4:00 AM

This revision is now accepted and ready to land.May 16 2023, 4:00 AM

ashoat added a child revision: D7829: [native] Rename RegistrationContainer to RegistrationContentContainer.May 16 2023, 4:08 AM

Closed by commit rCOMM08bf2853b10b: [native] Disable overscroll for RegistrationContainer on iOS (authored by ashoat). · Explain WhyMay 16 2023, 5:59 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM08bf2853b10b: [native] Disable overscroll for RegistrationContainer on iOS.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

registration-container.react.js

1 line

Diff 26532

native/account/registration/registration-container.react.js

Loading...