Page MenuHomePhabricator
Differential D7990

[native] Minor updates to UsernameSelection
ClosedPublic
Actions

Authored by ashoat on May 25 2023, 12:12 PM.
Tags
None
Referenced Files
F3401976: D7990.id27081.diff
Mon, Dec 2, 2:47 PM
F3401940: D7990.id27076.diff
Mon, Dec 2, 2:36 PM
F3401630: D7990.diff
Mon, Dec 2, 1:06 PM
Unknown Object (File)
Tue, Nov 5, 9:09 AM
Unknown Object (File)
Tue, Nov 5, 9:09 AM
Unknown Object (File)
Tue, Nov 5, 9:09 AM
Unknown Object (File)
Tue, Nov 5, 9:09 AM
Unknown Object (File)
Nov 1 2024, 9:46 AM
View All 90 Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM1192076525b1: [native] Minor updates to UsernameSelection
Summary

Two things I noticed while working on PasswordSelection:

  1. The same returnKeyType="go" change that I included in the previous diff (D7989).
  2. When checkUsernameValidity is called, if the username is valid we will now clear the usernameError.

Depends on D7989

Test Plan
  1. For returnKeyType="go", I confirmed the button was changed. For a visual indication of the change, check the previous diff.
  2. For the checkUsernameValidity change, I triggered a username error by typing in an invalid username (eg. starting with a - character). Then I focused the keyboard, fixed the error, and then dismissed the keyboard. I confirmed that the error text disappeared after the dismissal.

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/registration
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.May 25 2023, 12:12 PM
Herald added a subscriber: tomek. · View Herald TranscriptMay 25 2023, 12:12 PM
ashoat added inline comments.May 25 2023, 12:13 PM
native/account/registration/username-selection.react.js
54

I flipped the order of the conditions since they now had the same amount of code, and I figured it made more sense to have the "default" condition at end, in part for consistency with PasswordSelection which has two possible error states

ashoat added a child revision: D7992: [native] Implement PasswordSelection logic.May 25 2023, 12:27 PM
Harbormaster completed remote builds in B19783: Diff 27076.May 25 2023, 12:29 PM
ashoat requested review of this revision.May 25 2023, 12:29 PM
atul accepted this revision.May 25 2023, 2:00 PM
This revision is now accepted and ready to land.May 25 2023, 2:00 PM
Closed by commit rCOMM1192076525b1: [native] Minor updates to UsernameSelection (authored by ashoat). · Explain WhyMay 25 2023, 2:10 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM1192076525b1: [native] Minor updates to UsernameSelection.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
13 lines

Diff 27076

View Options

native/account/registration/username-selection.react.js

Loading...