This differential introduces methods on the keyeserver to check if olm sessions for notifs is missing and sends relevant request to client in case it is.
Details
Details
- Log out.
- Comment the code on native in log in panel that establishes olm session for notifs.
- Add console.log in the kesyerver to print if it is sending request for initial notifications encrypted message.
- Log in. Examine the logs.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/src/session/cookies.js | ||
|---|---|---|
| 841–843 ↗ | (On Diff #26782) | Nit: this query is more expensive than it needs to be, since it has to return the data. If you only need to check the number of rows, you can use COUNT (Also there is a trailing space on line 841) Note that if you use COUNT, you won't be able to check queryResult.length === 0 anymore... instead you will need to check queryResult[0].count === 0 |
| keyserver/src/session/cookies.js | ||
|---|---|---|
| 841 ↗ | (On Diff #26982) | There's a trailing space here. Please remove before landing! |
| keyserver/src/session/cookies.js | ||
|---|---|---|
| 833 ↗ | (On Diff #27217) | I am really sorry for making this mistake. The condition here should be: viewer.platformDetails.codeVersion <= 222 I will resolve this with git push to be fast. |