Paths

Table of Contentst

Differential D7657

Establish olm notifs session on both sides during registration
ClosedPublic
Actions

Authored by marcin on Apr 27 2023, 6:40 AM.

Tags

None

Referenced Files

	F1740379: D7657.id.diff
	Sun, May 12, 10:49 AM

	F1740174: D7657.id27341.diff
	Sun, May 12, 3:38 AM

	F1740171: D7657.id26006.diff
	Sun, May 12, 3:35 AM

	Unknown Object (File)
	Sat, May 11, 9:58 PM

	Unknown Object (File)
	Sat, May 11, 4:07 PM

	Unknown Object (File)
	Sat, May 11, 4:47 AM

	Unknown Object (File)
	Fri, May 10, 1:44 PM

	Unknown Object (File)
	Thu, May 9, 8:51 AM

Subscribers

Details

Reviewers

tomek
atul
bartek
ashoat

Commits

rCOMM7cbc1822445f: Establish olm notifs session on both sides during registration
rCOMM29f99ee4dfad: Establish olm notifs session on both sides during registration

Summary

This differential implements olm notifs session establishment during account creation.

Test Plan

Create new account. Ensure new entry in olm_sessions table appears

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Apr 27 2023, 6:40 AM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 27 2023, 6:40 AM

Harbormaster completed remote builds in B18859: Diff 25828.Apr 27 2023, 6:58 AM

marcin requested review of this revision.Apr 27 2023, 6:58 AM

marcin added a parent revision: D7654: Establish olm sessions for notifs on both sides during log-in.Apr 27 2023, 7:02 AM

marcin added a child revision: D7669: Establish olm notifs sessions during siwe account creation.Apr 27 2023, 8:15 AM

ashoat requested changes to this revision.Apr 27 2023, 1:10 PM

ashoat added inline comments.

keyserver/src/creators/account-creator.js
132–138 ↗	(On Diff #25828)	See feedback in D7654. Please be more thoughtful when introducing new `await` keywords
native/account/register-panel.react.js
295–297 ↗	(On Diff #25828)	See feedback in D7654. Please be more thoughtful when introducing new `await` keywords

This revision now requires changes to proceed.Apr 27 2023, 1:10 PM

Better usage of awaits. Ensure cookie iscreated prior to olm session.

Harbormaster completed remote builds in B18989: Diff 26006.May 2 2023, 8:57 AM

ashoat accepted this revision.May 2 2023, 10:13 AM

This revision is now accepted and ready to land.May 2 2023, 10:13 AM

Rebase

Harbormaster completed remote builds in B19286: Diff 26399.May 11 2023, 6:11 AM

Rebase before landing

Harbormaster completed remote builds in B19561: Diff 26742.May 22 2023, 2:15 AM

Rename call to get and rebase before landing

Harbormaster completed remote builds in B19570: Diff 26751.May 22 2023, 3:47 AM

Rebase before landing

Harbormaster completed remote builds in B19842: Diff 27173.May 29 2023, 12:02 PM

Closed by commit rCOMM29f99ee4dfad: Establish olm notifs session on both sides during registration (authored by marcin). · Explain WhyMay 29 2023, 1:41 PM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM29f99ee4dfad: Establish olm notifs session on both sides during registration.

ashoat added a reverting change: rCOMM080355ee6040: Revert "Establish olm notifs session on both sides during registration".May 31 2023, 4:51 AM

marcin reopened this revision.May 31 2023, 8:36 AM

This revision is now accepted and ready to land.May 31 2023, 8:36 AM

Rebase before landing

Harbormaster completed remote builds in B19951: Diff 27341.Jun 1 2023, 6:32 AM

Closed by commit rCOMM7cbc1822445f: Establish olm notifs session on both sides during registration (authored by marcin). · Explain WhyJun 1 2023, 6:55 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM7cbc1822445f: Establish olm notifs session on both sides during registration.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

account-creator.js

18 lines

responders/

user-responders.js

1 line

lib/

types/

account-types.js

1 line

native/

account/

register-panel.react.js

14 lines

Diff 27349

keyserver/src/creators/account-creator.js

Loading...

keyserver/src/responders/user-responders.js

Loading...

lib/types/account-types.js

Loading...

native/account/register-panel.react.js

Loading...