Page MenuHomePhabricator
Differential D8138

[web] Create a modal that allows admins to change a member's role (dropdown menu, actionable buttons)
ClosedPublic
Actions

Authored by rohan on Jun 7 2023, 5:04 AM.
Tags
None
Referenced Files
F3387634: D8138.id27515.diff
Fri, Nov 29, 10:28 AM
F3387523: D8138.id27545.diff
Fri, Nov 29, 9:49 AM
F3387406: D8138.id27704.diff
Fri, Nov 29, 9:19 AM
F3386994: D8138.diff
Fri, Nov 29, 7:08 AM
Unknown Object (File)
Thu, Nov 14, 3:48 PM
Unknown Object (File)
Thu, Nov 14, 3:09 PM
Unknown Object (File)
Sat, Nov 9, 3:49 PM
Unknown Object (File)
Sat, Nov 9, 2:19 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM19c63aa936b6: [web] Create a modal that allows admins to change a member's role (dropdown…
Summary

This is the second part of the modal creation, utilizing the earlier Dropdown component and creating the two 'back' and 'save' buttons. Functionality for these buttons will be added up the stack to
make this diff easier to review.

https://linear.app/comm/issue/ENG-4038/create-a-modal-that-allows-admins-to-change-a-members-role

Depends on D8137

Test Plan

Please see a screenshot of what the complete modal looks like now

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan created this revision.Jun 7 2023, 5:04 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 7 2023, 5:04 AM
rohan added a child revision: D8139: [web] Confirm a user wants to exit if changes are made in the modal.Jun 7 2023, 5:06 AM
Harbormaster completed remote builds in B20080: Diff 27515.Jun 7 2023, 5:21 AM
rohan requested review of this revision.Jun 7 2023, 5:21 AM
rohan edited the test plan for this revision. (Show Details)Jun 7 2023, 5:21 AM
rohan attached a referenced file: F575230: Screen Recording 2023-06-07 at 8.20.46 AM.mov. (Show Details)
rohan updated this revision to Diff 27545.Jun 8 2023, 6:10 AM

Rebase

Harbormaster completed remote builds in B20102: Diff 27545.Jun 8 2023, 6:27 AM
rohan updated this revision to Diff 27580.Jun 9 2023, 11:13 AM

Rebase on D8136

Harbormaster completed remote builds in B20130: Diff 27580.Jun 9 2023, 11:31 AM
atul retitled this revision from [web] Create a model that allows admins to change a member's role (dropdown menu, actionable buttons) to [web] Create a modal that allows admins to change a member's role (dropdown menu, actionable buttons).Jun 9 2023, 1:24 PM
atul accepted this revision.Jun 9 2023, 3:22 PM
This revision is now accepted and ready to land.Jun 9 2023, 3:22 PM
rohan updated this revision to Diff 27704.Jun 13 2023, 1:13 PM

Rebase

Harbormaster completed remote builds in B20226: Diff 27704.Jun 13 2023, 1:33 PM
rohan updated this revision to Diff 27939.Jun 21 2023, 8:04 AM

Rebase

Harbormaster completed remote builds in B20385: Diff 27939.Jun 21 2023, 8:29 AM
Closed by commit rCOMM19c63aa936b6: [web] Create a modal that allows admins to change a member's role (dropdown… (authored by rohan). · Explain WhyJun 21 2023, 8:41 AM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM19c63aa936b6: [web] Create a modal that allows admins to change a member's role (dropdown….

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
members/
21 lines
47 lines

Diff 27515

View Options

web/modals/threads/members/change-member-role-modal.css

Loading...
View Options

web/modals/threads/members/change-member-role-modal.react.js

Loading...