Page MenuHomePhabricator
Differential D8140

[web] Add functionality on save to actually change a member's role
ClosedPublic
Actions

Authored by rohan on Jun 7 2023, 5:08 AM.
Tags
None
Referenced Files
F3369520: D8140.id27582.diff
Mon, Nov 25, 10:47 PM
F3368368: D8140.diff
Mon, Nov 25, 7:29 PM
Unknown Object (File)
Tue, Nov 12, 12:40 AM
Unknown Object (File)
Sat, Nov 9, 3:00 PM
Unknown Object (File)
Sat, Nov 9, 2:01 PM
Unknown Object (File)
Sat, Nov 9, 1:22 PM
Unknown Object (File)
Sat, Nov 9, 12:19 PM
Unknown Object (File)
Sat, Nov 9, 11:39 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM3151ce9f22b4: [web] Add functionality on save to actually change a member's role
Summary

This diff adds functionality to clicking the save button, so when it is clicked the member's role is actually changed. There is already keyserver support for this, so the work here was entirely front
end.

https://linear.app/comm/issue/ENG-4040/add-functionality-on-save-to-actually-change-a-members-role

Depends on D8139

Test Plan

Please see the video below showing the working save button

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan created this revision.Jun 7 2023, 5:08 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 7 2023, 5:08 AM
rohan added a child revision: D8141: [web] Prevent changing the only admin role in a community.Jun 7 2023, 5:11 AM
Harbormaster completed remote builds in B20082: Diff 27517.Jun 7 2023, 5:25 AM
rohan requested review of this revision.Jun 7 2023, 5:25 AM
rohan edited the test plan for this revision. (Show Details)Jun 7 2023, 5:40 AM
rohan attached a referenced file: F575269: Screen Recording 2023-06-07 at 8.38.58 AM.mov. (Show Details)
ashoat added inline comments.Jun 7 2023, 2:16 PM
web/modals/threads/members/change-member-role-modal.react.js
71–79

Nit: this doesn't have to be an async function in order to return a promise

rohan updated this revision to Diff 27541.Jun 8 2023, 5:56 AM

Address inline comment

rohan updated this revision to Diff 27547.Jun 8 2023, 6:11 AM

Rebase

Harbormaster completed remote builds in B20098: Diff 27541.Jun 8 2023, 6:17 AM
Harbormaster completed remote builds in B20104: Diff 27547.Jun 8 2023, 6:30 AM
rohan updated this revision to Diff 27582.Jun 9 2023, 11:14 AM

Rebase on D8136

Harbormaster completed remote builds in B20132: Diff 27582.Jun 9 2023, 11:35 AM
atul accepted this revision.Jun 9 2023, 3:26 PM
This revision is now accepted and ready to land.Jun 9 2023, 3:26 PM
rohan edited child revisions, added: D8200: [keyserver] Prevent the only admin role from being changed on the keyserver; removed: D8141: [web] Prevent changing the only admin role in a community.Jun 13 2023, 1:46 PM
rohan updated this revision to Diff 27941.Jun 21 2023, 8:05 AM

Rebase

rohan added a child revision: D8141: [web] Prevent changing the only admin role in a community.Jun 21 2023, 8:05 AM
rohan removed a child revision: D8141: [web] Prevent changing the only admin role in a community.Jun 21 2023, 8:09 AM
This revision was landed with ongoing or failed builds.Jun 21 2023, 8:41 AM
Closed by commit rCOMM3151ce9f22b4: [web] Add functionality on save to actually change a member's role (authored by rohan). · Explain Why
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM3151ce9f22b4: [web] Add functionality on save to actually change a member's role.
Harbormaster completed remote builds in B20387: Diff 27941.Jun 21 2023, 8:42 AM
ashoat added inline comments.Jun 28 2023, 2:52 PM
web/modals/threads/members/change-member-role-modal.react.js
65–71 ↗(On Diff #27960)

Shorthand

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
members/
43 lines

Diff 27517

View Options

web/modals/threads/members/change-member-role-modal.react.js

Loading...