Page MenuHomePhabricator
Differential D8094

[Identity] Refactor access token verification to be more usable
ClosedPublic
Actions

Authored by • jon on Jun 5 2023, 7:34 AM.
Tags
None
Referenced Files
F1674605: D8094.diff
Sun, Apr 28, 4:34 PM
Unknown Object (File)
Sat, Apr 27, 9:32 AM
Unknown Object (File)
Thu, Apr 18, 2:44 AM
Unknown Object (File)
Thu, Apr 18, 2:44 AM
Unknown Object (File)
Thu, Apr 18, 2:44 AM
Unknown Object (File)
Thu, Apr 18, 2:44 AM
Unknown Object (File)
Thu, Apr 18, 2:44 AM
Unknown Object (File)
Thu, Apr 18, 2:39 AM
View All 55 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM5d9862b54918: [Identity] Refactor access token verification to be more usable
Summary

Verifying if an access token is valid will be a common
action with many of the API calls. We should make this as ergonomic
as possible.

Part of https://linear.app/comm/issue/ENG-3943

Test Plan

Set up identity service and localstack

nix develop

(cd services/identity && RUST_LOG=debug cargo run -- server)
(cd services/commtest && cargo test --test identity_access_tokens_tests)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jun 5 2023, 7:34 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 5 2023, 7:34 AM
• jon updated this revision to Diff 27444.Jun 5 2023, 7:52 AM

Allow test to run multiple times without failing

Harbormaster completed remote builds in B20023: Diff 27443.Jun 5 2023, 1:51 PM
Harbormaster completed remote builds in B20024: Diff 27444.
• jon requested review of this revision.Jun 5 2023, 1:53 PM
bartek accepted this revision.Jun 5 2023, 10:01 PM
This revision is now accepted and ready to land.Jun 5 2023, 10:01 PM
• jon added a child revision: D8126: [Protos] Update uploadOneTimeKeys to include device info and both sets of keys.Jun 6 2023, 10:39 AM
• jon added 1 blocking reviewer(s): varun.Jun 6 2023, 10:43 AM
This revision now requires review to proceed.Jun 6 2023, 10:43 AM
varun accepted this revision.Jun 6 2023, 11:54 AM
varun added inline comments.
services/commtest/tests/identity_access_tokens_tests.rs
28 ↗(On Diff #27444)

might be worth adding a comment above this line explaining that the device ID is the primary ed25519 public key from the above payload

This revision is now accepted and ready to land.Jun 6 2023, 11:54 AM
• jon updated this revision to Diff 27570.Jun 8 2023, 5:14 PM

Address feedback

Harbormaster completed remote builds in B20123: Diff 27570.Jun 8 2023, 5:32 PM
Closed by commit rCOMM5d9862b54918: [Identity] Refactor access token verification to be more usable (authored by • jon). · Explain WhyJun 11 2023, 8:03 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM5d9862b54918: [Identity] Refactor access token verification to be more usable.

Revision Contents
Changeset List

PathSize
services/
commtest/
2 lines
tests/
115 lines
identity/
src/
20 lines
21 lines

Diff 27570

View Options

services/commtest/Cargo.lock

Loading...
View Options

services/commtest/Cargo.toml

Loading...
View Options

services/commtest/tests/identity_access_tokens_tests.rs

Loading...
View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/database.rs

Loading...