Always better to be flexible with callers, so eg. a caller could pass an async function as setActiveSelection without causing Flow errors

We should be consistent in naming dropdown. Here we use dropDown but in the react component we use dropdown. I personally prefer the ladder

Not sure if this is part of the designs for the dropdown but, wondering if it would be good to have a default text to display if there is no activeOption. For example, in this case we could have the dropdown say "Select role..." or something like that if there is no activeOption

cc @ted

I don't actually think there should be a case where a user is displayed in the members list without a role - previously, we displayed parent admins in all chats, and they wouldn't have a role.

Now, since we only display parent admins part of chats they are actually a part of, they should have a role assigned to them (the Admins one). Once D8067's stack is landed, that should be addressed

Should this be converted into an invariant at some point then?

Yeah most likely, I can update this once the other stack is landed (I'll notice any other, if any, edge cases with roles being undefined once that's landed as well and can address it)

Hm, what's going on here?

This probably could've be implemented as a setter function, to avoid needing to regenerate toggleMenu every time isOpen changes:

setIsOpen(isOpen => !isOpen);

It feels like you're circumventing the design system here. Shouldn't we be using colors defined in web/theme.css?

I'll address this in a follow up diff

D8338