Page MenuHomePhabricator
Differential D8194

[native] Update KeyserverSelection to take URL instead of username as input
ClosedPublic
Actions

Authored by ashoat on Jun 13 2023, 10:16 AM.
Tags
None
Referenced Files
F3353410: D8194.id27727.diff
Sat, Nov 23, 9:48 AM
F3352951: D8194.diff
Sat, Nov 23, 7:28 AM
Unknown Object (File)
Fri, Nov 8, 6:47 PM
Unknown Object (File)
Fri, Nov 8, 3:27 PM
Unknown Object (File)
Wed, Nov 6, 7:26 PM
Unknown Object (File)
Wed, Nov 6, 7:26 PM
Unknown Object (File)
Wed, Nov 6, 7:26 PM
Unknown Object (File)
Wed, Nov 6, 7:26 PM
View All Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM8f5a657a9f98: [native] Update KeyserverSelection to take URL instead of username as input
Summary

Minor changes to indicate to the user that we are expecting them to input a URL.

Depends on D8193

Test Plan
  1. Confirm placeholder appears correctly
  2. Confirm on-screen keyboard includes ".com" key on iOS simulator

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Jun 13 2023, 10:16 AM
Herald added a subscriber: tomek. · View Herald TranscriptJun 13 2023, 10:16 AM
ashoat added a child revision: D8195: [native] Part 1: use user's keyserver selection in registration flow.Jun 13 2023, 10:16 AM
Harbormaster completed remote builds in B20213: Diff 27688.Jun 13 2023, 10:35 AM
ashoat requested review of this revision.Jun 13 2023, 10:35 AM
ginsu accepted this revision.Jun 13 2023, 12:08 PM
This revision is now accepted and ready to land.Jun 13 2023, 12:08 PM
ashoat mentioned this in D8198: [native] Add error handling to KeyserverSelection.Jun 14 2023, 6:04 AM
ashoat updated this revision to Diff 27727.Jun 14 2023, 6:11 AM

Disable autoCorrect following @ginsu's feedback in D8198. Also disabled autoCapitalize

This revision was landed with ongoing or failed builds.Jun 14 2023, 6:14 AM
Closed by commit rCOMM8f5a657a9f98: [native] Update KeyserverSelection to take URL instead of username as input (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM8f5a657a9f98: [native] Update KeyserverSelection to take URL instead of username as input.
Harbormaster completed remote builds in B20245: Diff 27727.Jun 14 2023, 6:28 AM

Revision Contents
Changeset List

PathSize
native/
account/
registration/
3 lines

Diff 27688

View Options

native/account/registration/keyserver-selection.react.js

Loading...