Page MenuHomePhabricator
Differential D8218

[native] Pull `displayFailureAlert` out of `EditThreadAvatarProvider`
ClosedPublic
Actions

Authored by atul on Jun 14 2023, 12:48 PM.
Tags
None
Referenced Files
F3505748: D8218.diff
Fri, Dec 20, 2:29 PM
Unknown Object (File)
Sat, Dec 7, 12:37 PM
Unknown Object (File)
Sat, Dec 7, 12:37 PM
Unknown Object (File)
Sat, Dec 7, 12:22 PM
Unknown Object (File)
Mon, Nov 25, 2:47 PM
Unknown Object (File)
Sat, Nov 23, 7:02 AM
Unknown Object (File)
Sat, Nov 23, 7:02 AM
Unknown Object (File)
Thu, Nov 21, 10:26 AM
View All 88 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMMb1dc05e767fb: [native] Pull `displayFailureAlert` out of `EditThreadAvatarProvider`
Summary

Similar to D8213, but for thread avatars (changes aren't 1:1 for both providers so separated changes even if there's a little redundancy... also the diffs should be less noisy so easier to review?)

Depends on D8217 (kinda)

Test Plan

Killed keyserver and made sure alert appeared as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
avatars/
15 lines
16 lines

Diff 27791

View Options

native/avatars/edit-thread-avatar-provider.react.js

Loading...
View Options

native/root.react.js

Loading...