Page MenuHomePhabricator
Differential D8223

[web] Change alert type in UserListItem
ClosedPublic
Actions

Authored by • kuba on Jun 15 2023, 1:20 AM.
Tags
None
Referenced Files
F5254165: D8223.diff
Sun, Apr 6, 6:58 AM
Unknown Object (File)
Tue, Mar 18, 6:45 AM
Unknown Object (File)
Sat, Mar 15, 5:05 PM
Unknown Object (File)
Fri, Mar 14, 3:34 PM
Unknown Object (File)
Fri, Mar 7, 6:34 PM
Unknown Object (File)
Fri, Mar 7, 6:34 PM
Unknown Object (File)
Fri, Mar 7, 6:34 PM
Unknown Object (File)
Fri, Mar 7, 6:33 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
michal
Commits
rCOMMb163ec8ca4f3: [web] Change alert type in UserListItem
Summary

A new version of: https://phab.comm.dev/D5583 (to avoid rebasing problems).

Raised in D5518, it doesn't make sense for only one of alertText and alertTitle to be defined. This diff changes the type to make sure they are always defined together and updates the usages.

Test Plan

Checked for flow errors. Check if thread composer works correctly on web and native.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• kuba created this revision.Jun 15 2023, 1:20 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 15 2023, 1:20 AM
• kuba added a parent revision: D6744: [keyserver] Block creating new chats with users that you are not friends with.Jun 15 2023, 1:21 AM
• kuba edited the summary of this revision. (Show Details)
• kuba mentioned this in D5583: [web] Change alert type in UserListItem.
• kuba added a child revision: D8224: [web] Unify behaviour of chat composer with native.Jun 15 2023, 1:26 AM
• kuba updated this revision to Diff 27803.Jun 15 2023, 1:30 AM

Display notice in userInfo

Harbormaster completed remote builds in B20280: Diff 27801.Jun 15 2023, 1:37 AM
Harbormaster completed remote builds in B20282: Diff 27803.Jun 15 2023, 1:46 AM
• kuba requested review of this revision.Jun 15 2023, 1:46 AM
michal accepted this revision.Jun 15 2023, 8:31 AM
This revision is now accepted and ready to land.Jun 15 2023, 8:31 AM
Closed by commit rCOMMb163ec8ca4f3: [web] Change alert type in UserListItem (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyJun 21 2023, 1:01 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMMb163ec8ca4f3: [web] Change alert type in UserListItem.

Revision Contents
Changeset List

PathSize
lib/
shared/
42 lines
types/
7 lines
native/
chat/
2 lines
components/
7 lines
web/
chat/
4 lines
modals/
components/
6 lines
threads/
members/
4 lines

Diff 27803

View Options

lib/shared/search-utils.js

<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0"> <plist version="1.0">
<dict> <dict>
<key>aps-environment</key> <key>aps-environment</key>
<string>development</string> <string>development</string>
<key>com.apple.developer.associated-domains</key> <key>com.apple.developer.associated-domains</key>
<array/> <array/>
<key>com.apple.security.application-groups</key>
<array>
<string>group.app.comm</string>
</array>
<key>keychain-access-groups</key> <key>keychain-access-groups</key>
<array> <array>
<string>$(AppIdentifierPrefix)app.comm</string> <string>$(AppIdentifierPrefix)app.comm</string>
</array> </array>
</dict> </dict>
</plist> </plist>
View Options

lib/types/user-types.js

<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0"> <plist version="1.0">
<dict> <dict>
<key>aps-environment</key> <key>aps-environment</key>
<string>development</string> <string>development</string>
<key>com.apple.developer.associated-domains</key> <key>com.apple.developer.associated-domains</key>
<array/> <array/>
<key>com.apple.security.application-groups</key>
<array>
<string>group.app.comm</string>
</array>
<key>keychain-access-groups</key> <key>keychain-access-groups</key>
<array> <array>
<string>$(AppIdentifierPrefix)app.comm</string> <string>$(AppIdentifierPrefix)app.comm</string>
</array> </array>
</dict> </dict>
</plist> </plist>
View Options

native/chat/message-list-thread-search.react.js

<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0"> <plist version="1.0">
<dict> <dict>
<key>aps-environment</key> <key>aps-environment</key>
<string>development</string> <string>development</string>
<key>com.apple.developer.associated-domains</key> <key>com.apple.developer.associated-domains</key>
<array/> <array/>
<key>com.apple.security.application-groups</key>
<array>
<string>group.app.comm</string>
</array>
<key>keychain-access-groups</key> <key>keychain-access-groups</key>
<array> <array>
<string>$(AppIdentifierPrefix)app.comm</string> <string>$(AppIdentifierPrefix)app.comm</string>
</array> </array>
</dict> </dict>
</plist> </plist>
View Options

native/components/user-list-user.react.js

<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0"> <plist version="1.0">
<dict> <dict>
<key>aps-environment</key> <key>aps-environment</key>
<string>development</string> <string>development</string>
<key>com.apple.developer.associated-domains</key> <key>com.apple.developer.associated-domains</key>
<array/> <array/>
<key>com.apple.security.application-groups</key>
<array>
<string>group.app.comm</string>
</array>
<key>keychain-access-groups</key> <key>keychain-access-groups</key>
<array> <array>
<string>$(AppIdentifierPrefix)app.comm</string> <string>$(AppIdentifierPrefix)app.comm</string>
</array> </array>
</dict> </dict>
</plist> </plist>
View Options

web/chat/chat-thread-composer.react.js

Loading...
View Options

web/modals/components/add-members-item.react.js

Loading...
View Options

web/modals/threads/members/add-members-list-content.react.js

Loading...